Bug 113945 - [Cairo] Stop passing raw pointers to BitmapImage::create()
Summary: [Cairo] Stop passing raw pointers to BitmapImage::create()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 113929
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-04 11:56 PDT by Chris Dumez
Modified: 2013-04-04 16:58 PDT (History)
12 users (show)

See Also:

Attachments
Patch (11.57 KB, patch)
2013-04-04 12:06 PDT, Chris Dumez 		mrobinson: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (12.31 KB, patch)
2013-04-04 13:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-04-04 11:56:56 PDT 
BitmapImage::create() now takes a PassRefPtr<cairo_surface_t> in argument instead of a cairo_surface_t*. Several call sites have not been updated because they were compiling and I missed them. We should stop silently converting cairo_surface_t* to PassRefPtr<cairo_surface_t> when calling BitmapImage::create().
Comment 1 Chris Dumez 2013-04-04 12:06:38 PDT 
Created attachment 196501 [details]
Patch
Comment 2 Chris Dumez 2013-04-04 13:36:31 PDT 
Comment on attachment 196501 [details]
Patch

GTK build error. I'll investigate.
Comment 3 Chris Dumez 2013-04-04 13:43:53 PDT 
Created attachment 196517 [details]
Patch for landing

minor fix for GTK build.
Comment 4 Chris Dumez 2013-04-04 16:57:48 PDT 
Committed r147683: <http://trac.webkit.org/changeset/147683>