Bug 113929 - [Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
Summary: [Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on: 113420
Blocks: 113945
  Show dependency treegraph
Reported: 2013-04-04 02:14 PDT by Chris Dumez
Modified: 2013-04-04 11:56 PDT (History)
17 users (show)

See Also:

Patch (83.50 KB, patch)
2013-04-04 07:02 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-04-04 02:14:24 PDT
NativeImageCairo only holds a RefPtr<cairo_surface_t> member. We could get rid of this unnecessary abstraction and have NativeImagePtr be typedef to RefPtr<cairo_surface_t>.
Comment 1 Chris Dumez 2013-04-04 02:30:22 PDT
svg/canvas/canvas-pattern-svg.html added in Bug 113420 is failing for Cairo due to SVGImage::nativeImageForCurrentFrame() implementation being disabled for Cairo.
Comment 2 Chris Dumez 2013-04-04 07:02:12 PDT
Created attachment 196475 [details]
Comment 3 WebKit Review Bot 2013-04-04 07:04:35 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 WebKit Review Bot 2013-04-04 10:58:05 PDT
Comment on attachment 196475 [details]

Clearing flags on attachment: 196475

Committed r147643: <http://trac.webkit.org/changeset/147643>
Comment 5 WebKit Review Bot 2013-04-04 10:58:10 PDT
All reviewed patches have been landed.  Closing bug.