Bug 113863 - [Qt] Move logic of simple forwarding functions to TestRunner.
Summary: [Qt] Move logic of simple forwarding functions to TestRunner.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on: 113393
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-03 03:28 PDT by Zeno Albisser
Modified: 2013-04-03 05:32 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.85 KB, patch)
2013-04-03 03:29 PDT, Zeno Albisser 		hausmann: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2013-04-03 03:28:48 PDT 
[Qt] Move logic of simple forwarding functions to TestRunner.
Comment 1 Zeno Albisser 2013-04-03 03:29:30 PDT 
Created attachment 196315 [details]
Patch
Comment 2 Simon Hausmann 2013-04-03 03:44:08 PDT 
Comment on attachment 196315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196315&action=review

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:833
> +    DumpRenderTree* drt = DumpRenderTree::instance();

Since what we need is the QWebPage and not the drt, you could also declare a local QWebPage *webPage variable instead of *drt
Comment 3 Zeno Albisser 2013-04-03 05:32:14 PDT 
Committed r147543: <http://trac.webkit.org/changeset/147543>