WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
Bug 113393
[Qt] Remove WorkQueue related functions from TestRunnerQt.
https://bugs.webkit.org/show_bug.cgi?id=113393
Summary
[Qt] Remove WorkQueue related functions from TestRunnerQt.
Zeno Albisser
Reported
2013-03-27 05:06:53 PDT
[Qt] Remove WorkQueue related functions from TestRunnerQt.
Attachments
Patch
(9.71 KB, patch)
2013-03-27 05:13 PDT
,
Zeno Albisser
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zeno Albisser
Comment 1
2013-03-27 05:13:46 PDT
Created
attachment 195283
[details]
Patch
Jocelyn Turcotte
Comment 2
2013-04-02 05:21:43 PDT
Comment on
attachment 195283
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=195283&action=review
> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:-334 > - for (int i = 0; i != howFarBackward; ++i) > - WorkQueue::shared()->queue(new BackItem(1));
This might regress
http://trac.webkit.org/changeset/69073
Please check.
> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:-341 > - for (int i = 0; i != howFarForward; ++i) > - WorkQueue::shared()->queue(new ForwardItem(1));
ditto
> Tools/DumpRenderTree/qt/WorkQueueItemQt.cpp:36 > +#include <qwebpage.h>
Nit: I might be missing it but I can't see a reference to QWebPage in the added code.
Jocelyn Turcotte
Comment 3
2014-02-03 03:25:29 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at
https://bugreports.qt-project.org
and add a link to this issue. See
http://qt-project.org/wiki/ReportingBugsInQt
for additional guidelines.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug