Bug 113393 - [Qt] Remove WorkQueue related functions from TestRunnerQt.
Summary: [Qt] Remove WorkQueue related functions from TestRunnerQt.
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
Depends on:
Blocks: 109677 113863
  Show dependency treegraph
Reported: 2013-03-27 05:06 PDT by Zeno Albisser
Modified: 2014-02-03 03:25 PST (History)
3 users (show)

See Also:

Patch (9.71 KB, patch)
2013-03-27 05:13 PDT, Zeno Albisser
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2013-03-27 05:06:53 PDT
[Qt] Remove WorkQueue related functions from TestRunnerQt.
Comment 1 Zeno Albisser 2013-03-27 05:13:46 PDT
Created attachment 195283 [details]
Comment 2 Jocelyn Turcotte 2013-04-02 05:21:43 PDT
Comment on attachment 195283 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=195283&action=review

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:-334
> -    for (int i = 0; i != howFarBackward; ++i)
> -        WorkQueue::shared()->queue(new BackItem(1));

This might regress http://trac.webkit.org/changeset/69073
Please check.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:-341
> -    for (int i = 0; i != howFarForward; ++i)
> -        WorkQueue::shared()->queue(new ForwardItem(1));


> Tools/DumpRenderTree/qt/WorkQueueItemQt.cpp:36
> +#include <qwebpage.h>

Nit: I might be missing it but I can't see a reference to QWebPage in the added code.
Comment 3 Jocelyn Turcotte 2014-02-03 03:25:29 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.