Bug 113726 - [CSS Exclusions] Add support for the simple case of shape-margin polygonal shape-outside
Summary: [CSS Exclusions] Add support for the simple case of shape-margin polygonal sh...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
Depends on:
Blocks: 112917
  Show dependency treegraph
Reported: 2013-04-01 15:36 PDT by Hans Muller
Modified: 2013-04-05 21:19 PDT (History)
6 users (show)

See Also:

Polygonal shape-margin illustration. (61.86 KB, image/png)
2013-04-03 20:08 PDT, Hans Muller
no flags Details
Patch (17.93 KB, patch)
2013-04-05 14:58 PDT, Hans Muller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-04-01 15:36:13 PDT
Compute the margin boundary of a polygon for the simple cases where the polygon is either convex, or the margin boundary has the same shape as the original polygon boundary.

This simplification is a first provisional step, similar to the one introduced for shape-padding.  See https://bugs.webkit.org/show_bug.cgi?id=112592.
Comment 1 Hans Muller 2013-04-03 20:08:22 PDT
Created attachment 196433 [details]
Polygonal shape-margin illustration.

The attached screenshot illustrates the margin-polygon for a polygonal shape. The edges of the (larger outer) margin-polygon are separated from the polygon by a  shape-margin value of about 100px.   Linear approximations to circular arcs join adjacent margin-polygon offset edges when the corresponding polygon edges do not meet at a reflex vertex.
Comment 2 Hans Muller 2013-04-05 14:58:47 PDT
Created attachment 196685 [details]
Comment 3 Dirk Schulze 2013-04-05 16:24:42 PDT
Comment on attachment 196685 [details]

LGTM. r=me.
Comment 4 WebKit Commit Bot 2013-04-05 21:19:35 PDT
Comment on attachment 196685 [details]

Clearing flags on attachment: 196685

Committed r147831: <http://trac.webkit.org/changeset/147831>
Comment 5 WebKit Commit Bot 2013-04-05 21:19:37 PDT
All reviewed patches have been landed.  Closing bug.