Bug 113660 – build-webkit doesn't support some build options

• Status: UNCONFIRMED
• Component: Tools / Tests

[Ed Bartosh]

Below is the list of build options from WebkitFeatures.cmake, which are not supported by webkit build(not present in FeatureList.pm):
ENABLE_ACCESSIBILITY
ENABLE_API_TESTS
ENABLE_ASSEMBLER_WX_EXCLUSIVE
ENABLE_DRAG_SUPPORT
ENABLE_ENABLE_MOUSE_CURSOR_SCALE
ENABLE_FAST_MOBILE_SCROLLING
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING
ENABLE_IMAGE_DECODER_DOWN_SAMPLING
ENABLE_JIT
ENABLE_LEGACY_VIEWPORT_ADAPTION
ENABLE_LLINT
ENABLE_MEMORY_SAMPLER
ENABLE_PLUGIN_PROXY_FOR_VIDEO
ENABLE_REPAINT_THROTTLING
ENABLE_SPELLCHECK
ENABLE_VIEW_MODE_CSS_MEDIA

[Ed Bartosh]

Created attachment 195897 [details]
Patch

[EFL EWS Bot]

Comment on attachment 195897 [details]
Patch

Attachment 195897 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17328596

[kov's GTK+ EWS bot]

Comment on attachment 195897 [details]
Patch

Attachment 195897 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17337421

[Ed Bartosh]

Created attachment 195899 [details]
Patch

[Ed Bartosh]

Created attachment 195901 [details]
Patch

[EFL EWS Bot]

Comment on attachment 195901 [details]
Patch

Attachment 195901 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17344248

[Ed Bartosh]

Created attachment 195902 [details]
Patch

[Ed Bartosh]

Created attachment 195903 [details]
Patch

[EFL EWS Bot]

Comment on attachment 195903 [details]
Patch

Attachment 195903 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17293477

[Ed Bartosh]

Created attachment 195905 [details]
Patch

[EFL EWS Bot]

Comment on attachment 195905 [details]
Patch

Attachment 195905 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17382120

[Ed Bartosh]

Created attachment 195906 [details]
Patch

[EFL EWS Bot]

Comment on attachment 195906 [details]
Patch

Attachment 195906 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17340917

[kov's GTK+ EWS bot]

Comment on attachment 195906 [details]
Patch

Attachment 195906 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17240731

[Ed Bartosh]

Created attachment 195908 [details]
Patch

[WebKit Review Bot]

Attachment 195908 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/page/gtk/EventHandlerGtk.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Tools/ChangeLog', u'Tools/DumpRenderTree/AccessibilityUIElement.cpp', u'Tools/Scripts/webkitperl/FeatureList.pm']" exit_code: 1
Tools/DumpRenderTree/AccessibilityUIElement.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 195908 [details]
Patch

Attachment 195908 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17325413

[Ed Bartosh]

Added dependency to 113641. I'll move all build fixes there or to new bugs.

[Ed Bartosh]

Created attachment 195941 [details]
Patch

Removed all build fixes from the patch. Fixes will be added to dependent bugs.

[EFL EWS Bot]

Comment on attachment 195941 [details]
Patch

Attachment 195941 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17314748

[Ed Bartosh]

Created attachment 196728 [details]
Patch

[EFL EWS Bot]

Comment on attachment 196728 [details]
Patch

Attachment 196728 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17526330

[Ed Bartosh]

Created attachment 196882 [details]
Patch

[EFL EWS Bot]

Comment on attachment 196882 [details]
Patch

Attachment 196882 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17562026

[kov's GTK+ EWS bot]

Comment on attachment 196882 [details]
Patch

Attachment 196882 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17490054

[Ed Bartosh]

Created attachment 197144 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 197144 [details]
Patch

Attachment 197144 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17676041

[Ryosuke Niwa]

Comment on attachment 197144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197144&action=review

> Tools/Scripts/webkitperl/FeatureList.pm:524
> +    { option => "view-mode-css-media", desc => "Toggle Track support for the view-mode media Feature support",
> +      define => "ENABLE_VIEW_MODE_CSS_MEDIA", default => 1, value => \$viewModeCssMediaSupport },

Why is this default 1? I don't think Mac enables this feature by default. r-.

[Ed Bartosh]

I took default values of all options from Source/cmake/WebKitFeatures.cmake. By default ENABLE_VIEW_MODE_CSS_MEDIA is enabled there:
WEBKIT_OPTION_DEFINE(ENABLE_VIEW_MODE_CSS_MEDIA "Toggle Track support for the view-mode media Feature" ON)

[Ed Bartosh]

Created attachment 201186 [details]
Patch

[Chris Dumez]

Comment on attachment 201186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201186&action=review

> Tools/Scripts/webkitperl/FeatureList.pm:525
> +      define => "ENABLE_VIEW_MODE_CSS_MEDIA", default => 1, value => \$viewModeCssMediaSupport },

You did not take rniwa's feedback into consideration. As far as I know, EFL, BlackBerry and GTK and the only ports enabling this. This should therefore probably be (isEfl() || isGtk() || isBlackBerry()) instead of 1.

You need to do similar checks for all the features or you are likely to break other ports. Not all the ports are using CMake and even those using CMake may override the default valye in WebKitFeatures.cmake.

[Ed Bartosh]

Christophe, thank you for the explanations. Now I started to understand where I'm wrong with this patch.

I was actually taking Niwa's comment into consideration, but didn't understand the whole thing. I've submitted patch again just to see where it'll break the build.

[kov's GTK+ EWS bot]

Comment on attachment 201186 [details]
Patch

Attachment 201186 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/277084

[Ed Bartosh]

Christophe, can you please explain where can I check default build options for different platforms? It's still unclear to me.

[Chris Dumez]

(In reply to comment #34)
> Christophe, can you please explain where can I check default build options for different platforms? It's still unclear to me.

I work mostly on EFL port so this is not 100% clear for me either. My current guess is:
- mac: Source/WebCore/Configurations/FeatureDefines.xcconfig
- EFL: Source/cmake/OptionsEfl.cmake -> Source/cmake/WebKitFeatures.cmake
- BlackBerry: Source/cmake/OptionsBlackBerry.cmake -> Source/cmake/WebKitFeatures.cmake
- GTK: Source/autotools/SetupWebKitFeatures.m4
- Qt: I think it is using build-webkit only

[Ed Bartosh]

Created attachment 201471 [details]
Patch

[Ed Bartosh]

Christophe, thank you! I looked into all those files and set up defaults accordingly.

[kov's GTK+ EWS bot]

Comment on attachment 201471 [details]
Patch

Attachment 201471 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/375257