Bug 113951 - [EFL] --minimal build fails with error: `setSeamlessIFramesEnabled' is not a member of `WebCore::RuntimeEnabledFeatures'
Summary: [EFL] --minimal build fails with error: `setSeamlessIFramesEnabled' is not a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Ed Bartosh
URL:
Keywords:
Depends on:
Blocks: 113660
  Show dependency tree / graph
 
Reported: 2013-04-04 13:04 PDT by Ed Bartosh
Modified: 2013-04-09 07:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2013-04-04 13:11 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Patch (2.42 KB, patch)
2013-04-06 06:43 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Patch (2.42 KB, patch)
2013-04-07 13:24 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Patch (2.48 KB, patch)
2013-04-08 10:28 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Bartosh 2013-04-04 13:04:22 PDT 
./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error:

/home/ed/git/wk/WebKit/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp: In static member function `static void DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled(bool)':
/home/ed/git/wk/WebKit/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:316:5: error: `setSeamlessIFramesEnabled' is not a member of `WebCore::RuntimeEnabledFeatures'
make[2]: *** [Source/WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp.o] Error 1
make[1]: *** [Source/WebKit/CMakeFiles/ewebkit.dir/all] Error 2
Comment 1 Ed Bartosh 2013-04-04 13:11:21 PDT 
Created attachment 196510 [details]
Patch
Comment 2 Ed Bartosh 2013-04-06 06:43:09 PDT 
Created attachment 196733 [details]
Patch

Rebased. Please, review.
Comment 3 Ed Bartosh 2013-04-07 13:24:19 PDT 
Created attachment 196808 [details]
Patch

Rebased again. Please review.
Comment 4 Gyuyoung Kim 2013-04-07 17:02:03 PDT 
Comment on attachment 196808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196808&action=review

> Source/WebKit/efl/ChangeLog:8
> +        Wrapped code related to iframe seamless into #if ENABLE(IFRAME_SEAMLESS)

Missing a new line.
Comment 5 Ed Bartosh 2013-04-08 10:28:12 PDT 
Created attachment 196869 [details]
Patch
Comment 6 Laszlo Gombos 2013-04-09 07:03:30 PDT 
Comment on attachment 196869 [details]
Patch

ok.
Comment 7 WebKit Commit Bot 2013-04-09 07:34:23 PDT 
Comment on attachment 196869 [details]
Patch

Clearing flags on attachment: 196869

Committed r148023: <http://trac.webkit.org/changeset/148023>
Comment 8 WebKit Commit Bot 2013-04-09 07:34:26 PDT 
All reviewed patches have been landed.  Closing bug.