Bug 113658 - [CSSRegions] RenderFlowThread should not be created as a Document renderer
Summary: [CSSRegions] RenderFlowThread should not be created as a Document renderer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihnea Ovidenie
URL:
Keywords: AdobeTracked
Depends on:
Blocks:
 
Reported: 2013-03-31 03:44 PDT by Mihnea Ovidenie
Modified: 2013-04-02 11:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.27 KB, patch)
2013-03-31 04:12 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
Patch for landing (10.94 KB, patch)
2013-04-02 00:51 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2013-03-31 03:44:37 PDT 
After https://bugs.webkit.org/show_bug.cgi?id=107138, RenderFlowThread should not be constructed as a renderer for Document. Since it does not have an element associated, it will be constructed using the pattern for anonymous blocks.
Comment 1 Mihnea Ovidenie 2013-03-31 04:12:49 PDT 
Created attachment 195892 [details]
Patch
Comment 2 Mihnea Ovidenie 2013-04-02 00:51:20 PDT 
Created attachment 196087 [details]
Patch for landing
Comment 3 WebKit Review Bot 2013-04-02 03:36:40 PDT 
Comment on attachment 196087 [details]
Patch for landing

Clearing flags on attachment: 196087

Committed r147414: <http://trac.webkit.org/changeset/147414>
Comment 4 WebKit Review Bot 2013-04-02 03:36:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Dave Hyatt 2013-04-02 11:09:44 PDT 
Comment on attachment 196087 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=196087&action=review

> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:45
> +    ASSERT(document->cssRegionsEnabled());

You should remove this line. Ultimately multicolumn layout will be on even if the CSS Regions feature is not.