Bug 113644 - Gradient background does not get repainted when child box is expanded.
Summary: Gradient background does not get repainted when child box is expanded.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-30 14:03 PDT by zalan
Modified: 2013-03-31 22:52 PDT (History)
6 users (show)

See Also:

Attachments
test case (666 bytes, text/html)
2013-03-30 14:03 PDT, zalan 		no flags Details
Patch (7.26 KB, patch)
2013-03-31 10:11 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2013-03-30 14:03:22 PDT 
Created attachment 195872 [details]
test case

When parent box has gradient background and child box height changes (expand), only expanded area gets invalidated.
Gradient looks broken until the next repaint.

see attached test case.
Comment 1 zalan 2013-03-30 14:11:31 PDT 
<rdar://problem/13048858>
Comment 2 Allan Sandfeld Jensen 2013-03-30 16:17:01 PDT 
This sounds like it also part the same problem as in bug 113313. The gradient is not only broken because the top is not repainted, but the bottom is also painted wrong (with the full gradient) because partial repaint is not working.
Comment 3 zalan 2013-03-30 23:53:16 PDT 
(In reply to comment #2)
> This sounds like it also part the same problem as in bug 113313. The gradient is not only broken because the top is not repainted, but the bottom is also painted wrong (with the full gradient) because partial repaint is not working.

Thanks for the headsup. I'll check, though this test case is fixed simply by issuing repaint for the parent box. Patch is coming up.
Comment 4 zalan 2013-03-31 10:11:58 PDT 
Created attachment 195898 [details]
Patch
Comment 5 Antti Koivisto 2013-03-31 14:52:51 PDT 
Comment on attachment 195898 [details]
Patch

cool r=me
Comment 6 WebKit Review Bot 2013-03-31 22:52:34 PDT 
Comment on attachment 195898 [details]
Patch

Clearing flags on attachment: 195898

Committed r147303: <http://trac.webkit.org/changeset/147303>
Comment 7 WebKit Review Bot 2013-03-31 22:52:38 PDT 
All reviewed patches have been landed.  Closing bug.