Bug 113313 – Background gradient is not correctly redrawn on partial repaint

• Status: UNCONFIRMED
• Component: CSS

[Stephane Cerveau]

Created attachment 195095 [details]
Test case

In attachment here is an example.
This is a combination with a div containing a gradient background, a left border and a repeat.
In this case we move a blue cursor which is creating a partial update on the background. In this case the background is not correctly redrawn.

[Stephane Cerveau]

Created attachment 195096 [details]
screenshot

This is what happens when pressing a key.

[Stephane Cerveau]

Created attachment 195109 [details]
Test if its a generated image to avoid partial redraw

[WebKit Review Bot]

Attachment 195109 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/GeneratedImage.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/Image.h']" exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Stephane Cerveau]

Created attachment 195518 [details]
Patch to disable partial updates for generated background image

Add bug review number in Changelog

[WebKit Review Bot]

Comment on attachment 195518 [details]
Patch to disable partial updates for generated background image

Attachment 195518 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17298403

New failing tests:
fast/gradients/css3-radial-gradients2.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
fast/dom/HTMLMeterElement/meter-appearances-capacity.html
fast/gradients/css3-radial-gradients3.html
fast/backgrounds/size/contain-and-cover-zoomed.html
fast/gradients/css3-linear-angle-gradients.html
fast/gradients/css3-repeating-linear-gradients.html
fast/dom/HTMLMeterElement/meter-element.html
fast/gradients/unprefixed-color-stop-units.html
fast/gradients/css3-color-stop-units.html
fast/gradients/unprefixed-radial-gradients2.html
fast/gradients/unprefixed-radial-gradients.html
fast/gradients/css3-repeating-linear-gradients2.html
fast/gradients/unprefixed-radial-gradients3.html
fast/gradients/unprefixed-linear-right-angle-gradients.html
http/tests/misc/last-modified-parsing.html
fast/gradients/css3-radial-gradients.html
fast/gradients/css3-color-stops.html
fast/backgrounds/size/contain-and-cover.html
fast/gradients/css3-linear-right-angle-gradients.html
css3/images/cross-fade-background-size.html
fast/dom/HTMLMeterElement/meter-styles.html
fast/gradients/unprefixed-repeating-linear-gradient.html
fast/gradients/unprefixed-linear-angle-gradients.html
fast/gradients/radial-centered.html
fast/dom/HTMLMeterElement/meter-optimums.html
fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html
fast/gradients/css3-repeating-radial-gradients.html
fast/dom/HTMLMeterElement/meter-boundary-values.html
fast/gradients/unprefixed-color-stops.html

[WebKit Review Bot]

Created attachment 195533 [details]
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[WebKit Review Bot]

Comment on attachment 195518 [details]
Patch to disable partial updates for generated background image

Attachment 195518 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17337183

New failing tests:
fast/gradients/css3-radial-gradients2.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
fast/dom/HTMLMeterElement/meter-appearances-capacity.html
fast/gradients/css3-radial-gradients3.html
fast/backgrounds/size/contain-and-cover-zoomed.html
fast/gradients/css3-linear-angle-gradients.html
fast/gradients/css3-repeating-linear-gradients.html
fast/gradients/unprefixed-repeating-radial-gradients.html
fast/dom/HTMLMeterElement/meter-element.html
fast/gradients/unprefixed-color-stop-units.html
fast/gradients/css3-color-stop-units.html
fast/gradients/unprefixed-radial-gradients2.html
fast/gradients/unprefixed-radial-gradients.html
fast/gradients/css3-repeating-linear-gradients2.html
fast/gradients/unprefixed-radial-gradients3.html
fast/gradients/unprefixed-linear-right-angle-gradients.html
fast/gradients/css3-radial-gradients.html
fast/gradients/css3-color-stops.html
fast/backgrounds/size/contain-and-cover.html
fast/gradients/css3-linear-right-angle-gradients.html
css3/images/cross-fade-background-size.html
fast/dom/HTMLMeterElement/meter-styles.html
fast/gradients/unprefixed-repeating-linear-gradient.html
fast/gradients/unprefixed-linear-angle-gradients.html
fast/gradients/radial-centered.html
fast/dom/HTMLMeterElement/meter-optimums.html
fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html
fast/gradients/css3-repeating-radial-gradients.html
fast/dom/HTMLMeterElement/meter-boundary-values.html
fast/gradients/unprefixed-color-stops.html

[WebKit Review Bot]

Created attachment 195545 [details]
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Allan Sandfeld Jensen]

Note this is not Qt specific. The issue seems to be that GeneratorGeneratedImage::draw can not do paints where the srcRect is not the size of m_size.

[Stephane Cerveau]

According to this patch, https://bugs.webkit.org/show_bug.cgi?id=87094, draw does not use cache which would allow to increase performance. I'm wondering if the use of draw in Image::drawTiled is really necessary ?

[Allan Sandfeld Jensen]

I think it would be worthwhile to check if this problem has been solved after the patch for bug 113644 has landed.

[zalan]

(In reply to comment #11)
> I think it would be worthwhile to check if this problem has been solved after the patch for bug 113644 has landed.

No, unfortunately it's not fixed by bug 113644