Bug 113619 - FTL should force LLVM to use our own JIT memory allocator, and we shouldn't have to keep around an LLVMExecutionEngineRef to keep code alive
Summary: FTL should force LLVM to use our own JIT memory allocator, and we shouldn't h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840 113620
  Show dependency tree / graph
 
Reported: 2013-03-29 16:08 PDT by Filip Pizlo
Modified: 2013-05-22 10:01 PDT (History)
7 users (show)

See Also:

Attachments
LLVM patch to expose MCJITMemoryManager callbacks (14.91 KB, patch)
2013-05-15 15:08 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (11.29 KB, patch)
2013-05-15 15:09 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
LLVM patch to expose MCJITMemoryManager callbacks (19.48 KB, patch)
2013-05-15 15:12 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
LLVM patch to expose MCJITMemoryManager callbacks (26.93 KB, patch)
2013-05-15 18:52 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
new patch for LLVM (31.53 KB, patch)
2013-05-18 09:11 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (11.15 KB, patch)
2013-05-18 09:12 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-03-29 16:08:20 PDT 
FTL should force LLVM to use our own JIT memory allocator.
Comment 1 Filip Pizlo 2013-05-15 15:08:37 PDT 
Created attachment 201888 [details]
LLVM patch to expose MCJITMemoryManager callbacks
Comment 2 Filip Pizlo 2013-05-15 15:09:59 PDT 
Created attachment 201889 [details]
the patch
Comment 3 Filip Pizlo 2013-05-15 15:12:00 PDT 
Created attachment 201890 [details]
LLVM patch to expose MCJITMemoryManager callbacks
Comment 4 Geoffrey Garen 2013-05-15 15:17:01 PDT 
Comment on attachment 201889 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201889&action=review

r=me

> Source/JavaScriptCore/ftl/FTLCompile.cpp:43
> +static uint8_t *allocateCodeSection(

Move the star, please. And below.

> Source/JavaScriptCore/ftl/FTLCompile.cpp:54
> +            state.graph.m_vm, size, state.graph.m_codeBlock, JITCompilationMustSucceed);

Maybe link to the bug here about must succeed.
Comment 5 Filip Pizlo 2013-05-15 18:52:31 PDT 
Created attachment 201909 [details]
LLVM patch to expose MCJITMemoryManager callbacks
Comment 6 Filip Pizlo 2013-05-18 09:11:19 PDT 
Created attachment 202207 [details]
new patch for LLVM
Comment 7 Filip Pizlo 2013-05-18 09:12:19 PDT 
Created attachment 202208 [details]
the patch
Comment 8 Filip Pizlo 2013-05-22 10:01:09 PDT 
Landed in http://trac.webkit.org/changeset/150520