Bug 113541 - [HTMLTemplateElement] <template> should be able to be a foster parent
Summary: [HTMLTemplateElement] <template> should be able to be a foster parent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Weinstein
URL:
Keywords:
Depends on:
Blocks: 103547
  Show dependency treegraph
 
Reported: 2013-03-28 15:43 PDT by Rafael Weinstein
Modified: 2013-03-28 17:11 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.38 KB, patch)
2013-03-28 15:45 PDT, Rafael Weinstein
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-01 for chromium-linux-x86_64 (1.37 MB, application/zip)
2013-03-28 16:45 PDT, WebKit Review Bot
no flags Details
Patch for landing (3.38 KB, patch)
2013-03-28 16:50 PDT, Rafael Weinstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Weinstein 2013-03-28 15:43:48 PDT
e.g. <template><table>Foo

'Foo' will get foster-parented and, per the spec, "The foster parent element is the parent element of the last table element in the stack of open elements, if there is a table element and it has such a parent element". In this case, the <template> is that parent element.
Comment 1 Rafael Weinstein 2013-03-28 15:45:59 PDT
Created attachment 195663 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-03-28 15:55:22 PDT
Comment on attachment 195663 [details]
Patch

OK.
Comment 3 WebKit Review Bot 2013-03-28 16:45:00 PDT
Comment on attachment 195663 [details]
Patch

Rejecting attachment 195663 [details] from commit-queue.

New failing tests:
fast/parser/remove-current-node-parent.html
Full output: http://webkit-commit-queue.appspot.com/results/17359021
Comment 4 WebKit Review Bot 2013-03-28 16:45:03 PDT
Created attachment 195678 [details]
Archive of layout-test-results from gce-cq-01 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-01  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 5 Rafael Weinstein 2013-03-28 16:50:27 PDT
Created attachment 195680 [details]
Patch for landing
Comment 6 Rafael Weinstein 2013-03-28 16:50:54 PDT
needed null check in both places. fixed.
Comment 7 WebKit Review Bot 2013-03-28 17:11:23 PDT
Comment on attachment 195680 [details]
Patch for landing

Clearing flags on attachment: 195680

Committed r147185: <http://trac.webkit.org/changeset/147185>
Comment 8 WebKit Review Bot 2013-03-28 17:11:27 PDT
All reviewed patches have been landed.  Closing bug.