Bug 113412 - Web Inspector: Separate JavaScriptSourceFrame popover from knowledge of editor's DOM
Summary: Web Inspector: Separate JavaScriptSourceFrame popover from knowledge of edito...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on: 113340 113344 113346 113389 113390
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-27 08:35 PDT by Andrey Lushnikov
Modified: 2013-04-02 03:47 PDT (History)
9 users (show)

See Also:


Attachments
Patch (12.43 KB, patch)
2013-03-27 08:41 PDT, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (11.74 KB, patch)
2013-03-29 05:30 PDT, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (11.92 KB, patch)
2013-03-29 05:59 PDT, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (11.61 KB, patch)
2013-04-01 07:59 PDT, Andrey Lushnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-27 08:35:59 PDT
Separate JavaScriptSourceFrame popover from knowledge of editor's DOM by the means of 
- TextEditor.coordinateToCursorPosition
- TextEditor.cursorPositionToCoordinates
- TextEditor.tokenAtTextPosition
Comment 1 Andrey Lushnikov 2013-03-27 08:41:03 PDT
Created attachment 195333 [details]
Patch
Comment 2 Andrey Lushnikov 2013-03-29 05:30:55 PDT
Created attachment 195727 [details]
Patch
Comment 3 Andrey Lushnikov 2013-03-29 05:59:10 PDT
Created attachment 195732 [details]
Patch
Comment 4 Andrey Lushnikov 2013-04-01 07:59:25 PDT
Created attachment 195970 [details]
Patch
Comment 5 WebKit Review Bot 2013-04-02 03:47:54 PDT
Comment on attachment 195970 [details]
Patch

Clearing flags on attachment: 195970

Committed r147415: <http://trac.webkit.org/changeset/147415>
Comment 6 WebKit Review Bot 2013-04-02 03:47:58 PDT
All reviewed patches have been landed.  Closing bug.