Bug 113346 - Web Inspector: [DTE] Paint overlay highlight over line background color
Summary: Web Inspector: [DTE] Paint overlay highlight over line background color
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks: 113412
  Show dependency tree / graph
 
Reported: 2013-03-26 14:53 PDT by Andrey Lushnikov
Modified: 2013-03-28 05:10 PDT (History)
12 users (show)

See Also:

Attachments
Patch (50.61 KB, patch)
2013-03-26 14:58 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (50.58 KB, patch)
2013-03-27 08:21 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 (691.56 KB, application/zip)
2013-03-27 09:10 PDT, WebKit Review Bot 		no flags Details
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (559.34 KB, application/zip)
2013-03-27 09:31 PDT, Build Bot 		no flags Details
Patch (50.67 KB, patch)
2013-03-28 03:55 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-26 14:53:34 PDT 
Paint overlay highlight over line background color in DefaultTextEditor.js.
Comment 1 Andrey Lushnikov 2013-03-26 14:58:50 PDT 
Created attachment 195171 [details]
Patch
Comment 2 Andrey Lushnikov 2013-03-27 08:21:34 PDT 
Created attachment 195330 [details]
Patch
Comment 3 WebKit Review Bot 2013-03-27 09:10:43 PDT 
Comment on attachment 195330 [details]
Patch

Attachment 195330 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17289586

New failing tests:
inspector/editor/text-editor-highlight-api.html
inspector/editor/text-editor-show-whitespace.html
inspector/editor/text-editor-remove-chunks-from-dom.html
inspector/editor/text-editor-type-over-decoration.html
inspector/editor/text-editor-highlight-token.html
inspector/editor/text-editor-brace-highlighter.html
inspector/editor/text-editor-long-line.html
Comment 4 WebKit Review Bot 2013-03-27 09:10:46 PDT 
Created attachment 195337 [details]
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 5 Build Bot 2013-03-27 09:31:48 PDT 
Comment on attachment 195330 [details]
Patch

Attachment 195330 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17338180

New failing tests:
inspector/editor/text-editor-highlight-api.html
inspector/editor/text-editor-show-whitespace.html
inspector/editor/text-editor-remove-chunks-from-dom.html
inspector/editor/text-editor-type-over-decoration.html
inspector/editor/text-editor-highlight-token.html
inspector/editor/text-editor-brace-highlighter.html
inspector/editor/text-editor-long-line.html
Comment 6 Build Bot 2013-03-27 09:31:50 PDT 
Created attachment 195343 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 7 Andrey Lushnikov 2013-03-28 03:55:45 PDT 
Created attachment 195522 [details]
Patch
Comment 8 WebKit Review Bot 2013-03-28 05:09:58 PDT 
Comment on attachment 195522 [details]
Patch

Clearing flags on attachment: 195522

Committed r147095: <http://trac.webkit.org/changeset/147095>
Comment 9 WebKit Review Bot 2013-03-28 05:10:03 PDT 
All reviewed patches have been landed.  Closing bug.