WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
113176
Web Inspector: Graduate some new Inspector APIs to public
https://bugs.webkit.org/show_bug.cgi?id=113176
Summary
Web Inspector: Graduate some new Inspector APIs to public
Vladislav Kaznacheev
Reported
2013-03-25 01:53:07 PDT
There is a number of APIs that are stable enough to be fixed. Below is the output of the updated API validator(see
https://bugs.webkit.org/show_bug.cgi?id=113148
) listing the proposed changes: DOM.highlightNode.nodeId: required parameter is now optional Input: domain has been added Runtime.enable: command has been added Runtime.executionContextCreated: event has been added Page.clearGeolocationOverride: command has been added Page.setGeolocationOverride: command has been added Page.captureScreenshot: command has been added Debugger.setBreakpointByUrl.locations: optional response parameter is now required
Attachments
Patch
(6.83 KB, patch)
2013-03-25 01:59 PDT
,
Vladislav Kaznacheev
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Vladislav Kaznacheev
Comment 1
2013-03-25 01:59:01 PDT
Created
attachment 194802
[details]
Patch
Timothy Hatcher
Comment 2
2013-03-25 08:44:02 PDT
Nice first step. But lets go further. Surely more things are stable than that measly list! My proposed list: Page.Frame Page.FrameResourceTree Page.getResourceTree Page.getResourceContent Page.searchInResource Page.searchInResources Page.frame* (events) Network.FrameId *.frameId (parameters) DOM.performSearch DOM.getSearchResults DOM.discardSearchResults CSS.* (except named flow stuff)
WebKit Review Bot
Comment 3
2013-03-25 09:03:50 PDT
Comment on
attachment 194802
[details]
Patch Clearing flags on attachment: 194802 Committed
r146777
: <
http://trac.webkit.org/changeset/146777
>
WebKit Review Bot
Comment 4
2013-03-25 09:03:56 PDT
All reviewed patches have been landed. Closing bug.
Pavel Feldman
Comment 5
2013-03-25 09:04:15 PDT
(In reply to
comment #2
)
> Nice first step. But lets go further. Surely more things are stable than that measly list! > > My proposed list: > > Page.Frame > Page.FrameResourceTree > Page.getResourceTree > Page.getResourceContent > Page.searchInResource > Page.searchInResources > Page.frame* (events) > > Network.FrameId > > *.frameId (parameters) >
The ones above look good to me, they all match our plans.
> DOM.performSearch > DOM.getSearchResults > DOM.discardSearchResults
I don't see why not.
> > CSS.* (except named flow stuff)
CSS domain requires some heavy lifting, so I'd leave it for longer term...
Timothy Hatcher
Comment 6
2013-03-25 09:58:36 PDT
(In reply to
comment #5
)
> (In reply to
comment #2
) > > CSS.* (except named flow stuff) > > CSS domain requires some heavy lifting, so I'd leave it for longer term...
Where are the bugs tracking planned incompatible work? If there are none, then this domain is stable IMHO.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug