Bug 113176 - Web Inspector: Graduate some new Inspector APIs to public
Summary: Web Inspector: Graduate some new Inspector APIs to public
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vladislav Kaznacheev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-25 01:53 PDT by Vladislav Kaznacheev
Modified: 2013-03-25 09:58 PDT (History)
12 users (show)

See Also:


Attachments
Patch (6.83 KB, patch)
2013-03-25 01:59 PDT, Vladislav Kaznacheev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladislav Kaznacheev 2013-03-25 01:53:07 PDT
There is a number of APIs that are stable enough to be fixed.
Below is the output of the updated API validator(see https://bugs.webkit.org/show_bug.cgi?id=113148) listing the proposed changes:

    DOM.highlightNode.nodeId: required parameter is now optional
    Input: domain has been added
    Runtime.enable: command has been added
    Runtime.executionContextCreated: event has been added
    Page.clearGeolocationOverride: command has been added
    Page.setGeolocationOverride: command has been added
    Page.captureScreenshot: command has been added
    Debugger.setBreakpointByUrl.locations: optional response parameter is now required
Comment 1 Vladislav Kaznacheev 2013-03-25 01:59:01 PDT
Created attachment 194802 [details]
Patch
Comment 2 Timothy Hatcher 2013-03-25 08:44:02 PDT
Nice first step. But lets go further. Surely more things are stable than that measly list!

My proposed list:

Page.Frame
Page.FrameResourceTree
Page.getResourceTree
Page.getResourceContent
Page.searchInResource
Page.searchInResources
Page.frame* (events)

Network.FrameId

*.frameId (parameters)

DOM.performSearch
DOM.getSearchResults
DOM.discardSearchResults

CSS.* (except named flow stuff)
Comment 3 WebKit Review Bot 2013-03-25 09:03:50 PDT
Comment on attachment 194802 [details]
Patch

Clearing flags on attachment: 194802

Committed r146777: <http://trac.webkit.org/changeset/146777>
Comment 4 WebKit Review Bot 2013-03-25 09:03:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Pavel Feldman 2013-03-25 09:04:15 PDT
(In reply to comment #2)
> Nice first step. But lets go further. Surely more things are stable than that measly list!
> 
> My proposed list:
> 
> Page.Frame
> Page.FrameResourceTree
> Page.getResourceTree
> Page.getResourceContent
> Page.searchInResource
> Page.searchInResources
> Page.frame* (events)
> 
> Network.FrameId
> 
> *.frameId (parameters)
> 

The ones above look good to me, they all match our plans.

> DOM.performSearch
> DOM.getSearchResults
> DOM.discardSearchResults

I don't see why not.

> 
> CSS.* (except named flow stuff)

CSS domain requires some heavy lifting, so I'd leave it for longer term...
Comment 6 Timothy Hatcher 2013-03-25 09:58:36 PDT
(In reply to comment #5)
> (In reply to comment #2)
> > CSS.* (except named flow stuff)
> 
> CSS domain requires some heavy lifting, so I'd leave it for longer term...

Where are the bugs tracking planned incompatible work? If there are none, then this domain is stable IMHO.