RESOLVED FIXED113148
Web Inspector: Use generate-inspector-protocol-version to list valid public API changes 
https://bugs.webkit.org/show_bug.cgi?id=113148
Summary Web Inspector: Use generate-inspector-protocol-version to list valid public A...
Vladislav Kaznacheev
Reported 2013-03-24 00:03:38 PDT
generate-inspector-protocol-version script can check the current Inspector.json for incompatibilities with the fixed baseline version. It would be nice if it could also list all valid changes.
Attachments
Patch (18.28 KB, patch)
2013-03-24 00:12 PDT, Vladislav Kaznacheev 		no flags
DetailsFormatted DiffDiff
Patch (21.04 KB, patch)
2013-03-24 12:57 PDT, Vladislav Kaznacheev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vladislav Kaznacheev
Comment 1 2013-03-24 00:12:50 PDT
Created attachment 194737 [details] Patch
Pavel Feldman
Comment 2 2013-03-24 00:31:51 PDT
Comment on attachment 194737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194737&action=review > Source/WebCore/inspector/generate-inspector-protocol-version:61 > +def translate_messages(messages, subst_map): this is a fairly strange pattern. i'd rather build a diff using constants (added, removed, changed) and then formatted it using corresponding strings > Source/WebCore/inspector/generate-inspector-protocol-version:454 > + sys.stderr.write(" Public changes since %s\n" % version) This is not error. Just use print.
Vladislav Kaznacheev
Comment 3 2013-03-24 12:57:37 PDT
Created attachment 194764 [details] Patch
Vladislav Kaznacheev
Comment 4 2013-03-24 13:00:33 PDT
Comment on attachment 194737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194737&action=review >> Source/WebCore/inspector/generate-inspector-protocol-version:61 >> +def translate_messages(messages, subst_map): > > this is a fairly strange pattern. i'd rather build a diff using constants (added, removed, changed) and then formatted it using corresponding strings And I was so proud of it. Rewrote it in a more transparent way. >> Source/WebCore/inspector/generate-inspector-protocol-version:454 >> + sys.stderr.write(" Public changes since %s\n" % version) > > This is not error. Just use print. Done
WebKit Review Bot
Comment 5 2013-03-25 06:55:10 PDT
Comment on attachment 194764 [details] Patch Clearing flags on attachment: 194764 Committed r146765: <http://trac.webkit.org/changeset/146765>
WebKit Review Bot
Comment 6 2013-03-25 06:55:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.