Bug 113099 – EWS should use a human readable port name when uploading layout test archives

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryosuke Niwa]

EWS should use a human readable port name when uploading layout test archives

[Ryosuke Niwa]

Created attachment 194632 [details]
Fixes the bug

[Eric Seidel (no email)]

Comment on attachment 194632 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=194632&action=review

> Tools/Scripts/webkitpy/tool/bot/botinfo.py:34
> +    def __init__(self, tool, port_name):
>          self._tool = tool
> +        self._port_name = port_name

Kinda lame that it can't get this off the tool, but I tool doesn't have a modern Port object yet?  dpranke would know.  There is some dependency inversion currently as the modern "Port" object is also the "host" god-object for the layout_tests sub-system.  Host was created to solve this, but the dependncy has yet to be righted yet iirc.

[Dirk Pranke]

Comment on attachment 194632 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=194632&action=review

>> Tools/Scripts/webkitpy/tool/bot/botinfo.py:34
>> +        self._port_name = port_name
> 
> Kinda lame that it can't get this off the tool, but I tool doesn't have a modern Port object yet?  dpranke would know.  There is some dependency inversion currently as the modern "Port" object is also the "host" god-object for the layout_tests sub-system.  Host was created to solve this, but the dependncy has yet to be righted yet iirc.

I thought I had added one at some point, but I guess not.

[Ryosuke Niwa]

Committed r146691: <http://trac.webkit.org/changeset/146691>