Bug 113099 - EWS should use a human readable port name when uploading layout test archives
Summary: EWS should use a human readable port name when uploading layout test archives
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 92033
  Show dependency tree / graph
 
Reported: 2013-03-22 14:21 PDT by Ryosuke Niwa
Modified: 2013-03-22 17:33 PDT (History)
4 users (show)

See Also:

Attachments
Fixes the bug (7.52 KB, patch)
2013-03-22 14:36 PDT, Ryosuke Niwa 		dpranke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-03-22 14:21:02 PDT 
EWS should use a human readable port name when uploading layout test archives
Comment 1 Ryosuke Niwa 2013-03-22 14:36:55 PDT 
Created attachment 194632 [details]
Fixes the bug
Comment 2 Eric Seidel (no email) 2013-03-22 16:28:49 PDT 
Comment on attachment 194632 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=194632&action=review

> Tools/Scripts/webkitpy/tool/bot/botinfo.py:34
> +    def __init__(self, tool, port_name):
>          self._tool = tool
> +        self._port_name = port_name

Kinda lame that it can't get this off the tool, but I tool doesn't have a modern Port object yet?  dpranke would know.  There is some dependency inversion currently as the modern "Port" object is also the "host" god-object for the layout_tests sub-system.  Host was created to solve this, but the dependncy has yet to be righted yet iirc.
Comment 3 Dirk Pranke 2013-03-22 17:12:27 PDT 
Comment on attachment 194632 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=194632&action=review

>> Tools/Scripts/webkitpy/tool/bot/botinfo.py:34
>> +        self._port_name = port_name
> 
> Kinda lame that it can't get this off the tool, but I tool doesn't have a modern Port object yet?  dpranke would know.  There is some dependency inversion currently as the modern "Port" object is also the "host" god-object for the layout_tests sub-system.  Host was created to solve this, but the dependncy has yet to be righted yet iirc.

I thought I had added one at some point, but I guess not.
Comment 4 Ryosuke Niwa 2013-03-22 17:33:29 PDT 
Committed r146691: <http://trac.webkit.org/changeset/146691>