Bug 112949 - Coordinates.idl lacks Conditional=GEOLOCATION
Summary: Coordinates.idl lacks Conditional=GEOLOCATION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on: 112975
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-21 12:20 PDT by Steve Block
Modified: 2013-03-22 13:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2013-03-21 14:09 PDT, rich cannings
no flags Details | Formatted Diff | Diff
Patch (1.18 KB, patch)
2013-03-22 12:01 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2013-03-21 12:20:10 PDT
Coordinates.idl was added in http://trac.webkit.org/changeset/41650 and is used only by Geolocation. http://trac.webkit.org/changeset/56781 added the ENABLE_GEOLOCATION guard, but missed Coordinates.idl.
Comment 1 rich cannings 2013-03-21 14:09:47 PDT
Created attachment 194334 [details]
Patch
Comment 2 EFL EWS Bot 2013-03-21 14:26:28 PDT
Comment on attachment 194334 [details]
Patch

Attachment 194334 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17247268
Comment 3 Adam Barth 2013-03-21 14:27:10 PDT
Comment on attachment 194334 [details]
Patch

Should this move into Source/WebCore/Modules/geolocation ?
Comment 4 Steve Block 2013-03-21 15:05:10 PDT
> Should this move into Source/WebCore/Modules/geolocation ?
Yes - https://bugs.webkit.org/show_bug.cgi?id=112945
Comment 5 Steve Block 2013-03-21 16:07:56 PDT
The EFL failure is because the custom bindings for Coordinates aren't guarded with GEOLOCATION.

It seems a shame to add more guards there, but I think the problem can be avoided. The bindings generator now supports nullable types, so we should be able to remove the custom bindings altogether - Bug 112975
Comment 6 Build Bot 2013-03-21 22:08:34 PDT
Comment on attachment 194334 [details]
Patch

Attachment 194334 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17169891
Comment 7 Steve Block 2013-03-22 12:01:20 PDT
Created attachment 194612 [details]
Patch
Comment 8 Steve Block 2013-03-22 12:19:45 PDT
Comment on attachment 194612 [details]
Patch

Carrying forward abarth's r+
Comment 9 WebKit Review Bot 2013-03-22 13:16:33 PDT
Comment on attachment 194612 [details]
Patch

Clearing flags on attachment: 194612

Committed r146645: <http://trac.webkit.org/changeset/146645>
Comment 10 WebKit Review Bot 2013-03-22 13:16:36 PDT
All reviewed patches have been landed.  Closing bug.