Bug 112945 - Move page/Coordinates.[h|idl] to Modules/geolocation/
Summary: Move page/Coordinates.[h|idl] to Modules/geolocation/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 11:50 PDT by Steve Block
Modified: 2013-03-22 00:54 PDT (History)
11 users (show)

See Also:

Attachments
Patch (30.78 KB, patch)
2013-03-21 18:01 PDT, rich cannings 		no flags Details | Formatted Diff | Diff
Patch (30.78 KB, patch)
2013-03-21 19:46 PDT, rich cannings 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2013-03-21 11:50:30 PDT 
Coordinates.[h|idl] are used only by Geolocation. It looks like they were missed in https://bugs.webkit.org/show_bug.cgi?id=79204
Comment 1 rich cannings 2013-03-21 18:01:07 PDT 
Created attachment 194407 [details]
Patch
Comment 2 Build Bot 2013-03-21 18:51:01 PDT 
Comment on attachment 194407 [details]
Patch

Attachment 194407 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17213840
Comment 3 rich cannings 2013-03-21 19:46:00 PDT 
Created attachment 194422 [details]
Patch
Comment 4 Steve Block 2013-03-21 19:47:25 PDT 
Fixed XCode hashes
Comment 5 Kentaro Hara 2013-03-21 21:29:08 PDT 
You might want to add '#if ENABLE(GEOLOCATION)' to the header file and 'Conditional=GEOLOCATION' to the idl file.
Comment 6 Steve Block 2013-03-22 00:05:37 PDT 
> You might want to add '#if ENABLE(GEOLOCATION)' to the header file and 'Conditional=GEOLOCATION' to the idl file.
Yes, I'm doing that in Bug 112949
Comment 7 Kentaro Hara 2013-03-22 00:06:31 PDT 
Comment on attachment 194422 [details]
Patch

OK.
Comment 8 Steve Block 2013-03-22 00:08:06 PDT 
Comment on attachment 194422 [details]
Patch

Carrying forward abarth's r+
Comment 9 WebKit Review Bot 2013-03-22 00:54:34 PDT 
Comment on attachment 194422 [details]
Patch

Clearing flags on attachment: 194422

Committed r146570: <http://trac.webkit.org/changeset/146570>
Comment 10 WebKit Review Bot 2013-03-22 00:54:39 PDT 
All reviewed patches have been landed.  Closing bug.