Bug 112922 – Floor cell widths in AutoTableLayout::recalcColumn

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Table cells widths are floored to ensure even distribution of available space across columns. The code path that computes the width of the _table_ failed to take this into account and thus can over report the total width of the table.

Donstream chromium bug: https://code.google.com/p/chromium/issues/detail?id=179365

[Emil A Eklund]

Created attachment 194284 [details]
Patch

[Levi Weintraub]

Comment on attachment 194284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194284&action=review

> Source/WebCore/ChangeLog:11
> +        Table cells widths are floored to ensure even distribution of available
> +        space across columns. The code path that computes the width of the
> +        _table_ failed to take this into account and thus can over report the
> +        total width of the table.

Whoops!! Thanks Emil :)

> LayoutTests/ChangeLog:11
> +        * fast/sub-pixel/table-with-subpixel-cell-size-expected.html: Added.
> +        * fast/sub-pixel/table-with-subpixel-cell-size.html: Added.

Why no entries for the the changed expectations? Also, I presume this will trigger failures on other platforms as well?

> LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:10
>          RenderTable {TABLE} at (67,20) size 474x4525

Man this output sucks :(

[Build Bot]

Comment on attachment 194284 [details]
Patch

Attachment 194284 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17147616

New failing tests:
fast/transforms/bounding-rect-zoom.html
tables/mozilla_expected_failures/bugs/bug89315.html
fast/text/international/bidi-layout-across-linebreak.html

[Build Bot]

Created attachment 194295 [details]
Archive of layout-test-results from webkit-ews-14

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: <class 'webkitpy.common.config.ports.MacWK2Port'>  Platform: Mac OS X 10.8.2

[WebKit Review Bot]

Comment on attachment 194284 [details]
Patch

Attachment 194284 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17125828

New failing tests:
fast/text/international/bidi-layout-across-linebreak.html

[WebKit Review Bot]

Created attachment 194308 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Build Bot]

Comment on attachment 194284 [details]
Patch

Attachment 194284 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17212874

New failing tests:
fast/transforms/bounding-rect-zoom.html
tables/mozilla_expected_failures/bugs/bug89315.html
svg/custom/marker-orient-auto.html
fast/text/international/bidi-layout-across-linebreak.html

[Build Bot]

Created attachment 194385 [details]
Archive of layout-test-results from webkit-ews-07

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.8.2

[Build Bot]

Comment on attachment 194284 [details]
Patch

Attachment 194284 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17212891

New failing tests:
fast/transforms/bounding-rect-zoom.html
tables/mozilla_expected_failures/bugs/bug89315.html
svg/custom/marker-orient-auto.html
fast/text/international/bidi-layout-across-linebreak.html

[Build Bot]

Created attachment 194403 [details]
Archive of layout-test-results from webkit-ews-02

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.8.2

[Emil A Eklund]

Created attachment 194526 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 194526 [details]
Patch for landing

Clearing flags on attachment: 194526

Committed r146600: <http://trac.webkit.org/changeset/146600>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.