112697 – REGRESSION(r146164): It made all inspector tests timeout on ARM traditional with enabled DFG JIT

Bug 112697 - REGRESSION(r146164): It made all inspector tests timeout on ARM traditional with enabled DFG JIT

Summary: REGRESSION(r146164): It made all inspector tests timeout on ARM traditional w...

Status:	RESOLVED DUPLICATE of bug 116306

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P1 Critical
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:	108645 112599
	Show dependency tree / graph

Reported:	2013-03-19 07:26 PDT by Csaba Osztrogonác
Modified:	2013-05-28 03:24 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Csaba Osztrogonác 2013-03-19 07:26:39 PDT

I'm bisecting the culprit.

Comment 1 Csaba Osztrogonác 2013-03-19 07:38:21 PDT

It seems http://trac.webkit.org/changeset/146174 is the culprit or one of its
buildfix: http://trac.webkit.org/changeset/146178 or http://trac.webkit.org/changeset/146195

See r146178 results with applied the fix from r146195:
http://cute1.inf.u-szeged.hu:8010/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/8093

Comment 2 Csaba Osztrogonác 2013-03-19 08:51:10 PDT

The bug is valid with Thumb2 assembler too.

Comment 3 Csaba Osztrogonác 2013-03-19 08:53:00 PDT

Oh no, thumb2 result can be invalid, because the fix from https://bugs.webkit.org/show_bug.cgi?id=103146 haven't been landed.

Comment 4 Csaba Osztrogonác 2013-03-19 09:22:59 PDT

(In reply to comment #3)
> Oh no, thumb2 result can be invalid, because the fix from https://bugs.webkit.org/show_bug.cgi?id=103146 haven't been landed.

On r146178 + fix from r146195 + fix from bug103146, all inspector tests 
pass with Thumb2, so only ARM traditional is affected by this bug.

Comment 5 Csaba Osztrogonác 2013-03-19 10:02:08 PDT

Not r146174 is the culprit, but http://trac.webkit.org/changeset/146164.

r146146 + r146195 (buildfix): http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/8096

Comment 6 Csaba Osztrogonác 2013-03-19 16:20:01 PDT

I had to skip _all_ inspector test (r146275) to make the
ARM bot work again. (We can't wait for ~500x30 secs timeout)

Comment 7 Csaba Osztrogonác 2013-04-02 07:50:34 PDT

inspector tests pass with disabled DFG JIT: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/8209

So r146146 broke the ARM traditional with enabled DFG JIT only. :)

Comment 8 Csaba Osztrogonác 2013-05-28 03:24:03 PDT

Fixed by https://trac.webkit.org/changeset/150748 and tests were unskipped by https://trac.webkit.org/changeset/150794

*** This bug has been marked as a duplicate of bug 116306 ***