Bug 112680 – REGRESSION(r146174): It made jquery/manipulation.html fail on 32 bit platforms

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/146174 and http://trac.webkit.org/changeset/146178 made
jquery/manipulation.html fail on 32 bit platforms. At least on Qt, because only Qt
has 32 bit tester bot. See this diff for details:

http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r146178%20%2830468%29/jquery/manipulation-pretty-diff.html

[Ádám Kallai]

Skipped in: http://trac.webkit.org/changeset/146201

[Michael Saboff]

(In reply to comment #0)
> http://trac.webkit.org/changeset/146174 and http://trac.webkit.org/changeset/146178 made
> jquery/manipulation.html fail on 32 bit platforms. At least on Qt, because only Qt
> has 32 bit tester bot. See this diff for details:
> 
> http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r146178%20%2830468%29/jquery/manipulation-pretty-diff.html

Was there a crash with backtrace as well?

[Csaba Osztrogonác]

No, It is only fail, not crash.

[Michael Saboff]

Built r146178 32bit Mac WebKit and jquery/manipulation.html works fine for me.

[Alexey Proskuryakov]

This test is very slow, particularly in debug builds, but there doesn't appear to be anything 32-bit specific there any more. OK to close?

[Csaba Osztrogonác]

Created attachment 235831 [details]
diff from bot archive

[Csaba Osztrogonác]

(In reply to comment #5)
> This test is very slow, particularly in debug builds, but there doesn't appear to be anything 32-bit specific there any more. OK to close?

It is ~1.5 years old bug, who knows what happened during this long period.
There isn't QtWebKit anymore, there isn't any EFL or GTK 32 bit tester bot.

We only know that it was a valid 32 bit regression (diff attached) caused by
r146174 and r146178. And the test runtime wasn't slow at all, it ran on the
bot in 2 seconds, so it wasn't related to slowness at all.

[Csaba Osztrogonác]

I checked it on QtWebKit release branch (branched before removing from trunk)
and it passes now, so I assume it is already fixed on trunk too.