Bug 112665 - Implement and32 on MIPS platform
Summary: Implement and32 on MIPS platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 112599
  Show dependency tree / graph
 
Reported: 2013-03-18 23:45 PDT by Csaba Osztrogonác
Modified: 2013-03-20 07:08 PDT (History)
10 users (show)

See Also:

Attachments
speculative fix (1.23 KB, patch)
2013-03-19 01:37 PDT, Peter Gal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-03-18 23:45:57 PDT 
+++ This bug was initially created as a clone of Bug #112663 +++

http://trac.webkit.org/changeset/146164 broke the MIPS
build because of missing add32 implementation:

/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: In member function 'void JSC::DFG::SpeculativeJIT::compileAdd(JSC::DFG::Node*)':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3136: error: no matching function for call to 'JSC::DFG::JITCompiler::and32(JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Address, JSC::DFG::GPRReg&)'
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:270: note: candidates are: void JSC::MacroAssemblerMIPS::and32(JSC::MIPSRegisters::RegisterID, JSC::MIPSRegisters::RegisterID)
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:275: note:                 void JSC::MacroAssemblerMIPS::and32(JSC::MIPSRegisters::RegisterID, JSC::MIPSRegisters::RegisterID, JSC::MIPSRegisters::RegisterID)
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:280: note:                 void JSC::MacroAssemblerMIPS::and32(JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::TrustedImm32, JSC::MIPSRegisters::RegisterID)
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:296: note:                 void JSC::MacroAssemblerMIPS::and32(JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::TrustedImm32, JSC::MIPSRegisters::RegisterID, JSC::MIPSRegisters::RegisterID)
make[3]: *** [.obj/release-shared/dfg/DFGSpeculativeJIT.o] Error 1
Comment 1 Peter Gal 2013-03-19 00:01:32 PDT 
Please rename the bug. The 'and32' is missing not the 'add32'.
Comment 2 Peter Gal 2013-03-19 01:37:38 PDT 
Created attachment 193755 [details]
speculative fix

A MIPS guru should check this patch just to be on safe side.
Comment 3 Gergely Kis 2013-03-19 01:42:10 PDT 
Thanks for the patch, Balázs will check it first thing.
Comment 4 Balazs Kilvady 2013-03-19 03:43:43 PDT 
(In reply to comment #2)
> Created an attachment (id=193755) [details]
> speculative fix

The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests.
Comment 5 Peter Gal 2013-03-20 06:31:12 PDT 
(In reply to comment #4)
> (In reply to comment #2)
> > Created an attachment (id=193755) [details] [details]
> > speculative fix
> 
> The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests.

Ok, in the meantime I think we should commit this in, just to get the bot a little greener.
Comment 6 Balazs Kilvady 2013-03-20 07:02:24 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > Created an attachment (id=193755) [details] [details] [details]
> > > speculative fix
> > 
> > The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests.
> 
> Ok, in the meantime I think we should commit this in, just to get the bot a little greener.

Agree.
Comment 7 Zoltan Herczeg 2013-03-20 07:04:16 PDT 
Comment on attachment 193755 [details]
speculative fix

róme
Comment 8 WebKit Review Bot 2013-03-20 07:08:35 PDT 
Comment on attachment 193755 [details]
speculative fix

Clearing flags on attachment: 193755

Committed r146339: <http://trac.webkit.org/changeset/146339>
Comment 9 WebKit Review Bot 2013-03-20 07:08:39 PDT 
All reviewed patches have been landed.  Closing bug.