Bug 112663 - Implement and32 on ARMv7 and ARM traditional platforms
Summary: Implement and32 on ARMv7 and ARM traditional platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108645 112599
  Show dependency tree / graph
 
Reported: 2013-03-18 23:43 PDT by Csaba Osztrogonác
Modified: 2013-03-19 02:35 PDT (History)
7 users (show)

See Also:

Attachments
proposed fix (1.95 KB, patch)
2013-03-19 02:08 PDT, Gabor Rapcsanyi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-03-18 23:43:11 PDT 
http://trac.webkit.org/changeset/146164 broke the ARM traditional
build because of missing add32 implementation:

/home/webkitbuildbot/slaves/armQt5Release-buildonly/buildslave/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: In member function 'void JSC::DFG::SpeculativeJIT::compileAdd(JSC::DFG::Node*)':
/home/webkitbuildbot/slaves/armQt5Release-buildonly/buildslave/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3136:88: error: no matching function for call to 'JSC::DFG::JITCompiler::and32(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Address, JSC::DFG::GPRReg&)'
Comment 1 Peter Gal 2013-03-19 00:01:27 PDT 
Please rename the bug. The 'and32' is missing not the 'add32'.
Comment 2 Csaba Osztrogonác 2013-03-19 00:26:12 PDT 
(In reply to comment #1)
> Please rename the bug. The 'and32' is missing not the 'add32'.

Done.
Comment 3 Gabor Rapcsanyi 2013-03-19 02:08:38 PDT 
Created attachment 193765 [details]
proposed fix
Comment 4 Zoltan Herczeg 2013-03-19 02:13:10 PDT 
Comment on attachment 193765 [details]
proposed fix

r=me
Comment 5 WebKit Review Bot 2013-03-19 02:35:17 PDT 
Comment on attachment 193765 [details]
proposed fix

Clearing flags on attachment: 193765

Committed r146195: <http://trac.webkit.org/changeset/146195>
Comment 6 WebKit Review Bot 2013-03-19 02:35:20 PDT 
All reviewed patches have been landed.  Closing bug.