Bug 112460 - Support Windows HTMLSelectElement keystrokes on Chromium win
Summary: Support Windows HTMLSelectElement keystrokes on Chromium win
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Dominic Mazzoni
URL:
Keywords:
Depends on: 112540
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-15 13:15 PDT by Dominic Mazzoni
Modified: 2013-03-18 16:13 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.15 KB, patch)
2013-03-16 01:14 PDT, Dominic Mazzoni
no flags Details | Formatted Diff | Diff
Patch (2.83 KB, patch)
2013-03-16 01:32 PDT, Dominic Mazzoni
no flags Details | Formatted Diff | Diff
Patch (2.82 KB, patch)
2013-03-16 01:48 PDT, Dominic Mazzoni
no flags Details | Formatted Diff | Diff
Patch (3.10 KB, patch)
2013-03-18 09:18 PDT, Dominic Mazzoni
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2013-03-15 13:15:01 PDT
This bug added support for Windows-specific keystrokes to drop down the option list from a combo box:

    https://bugs.webkit.org/show_bug.cgi?id=22232 - Alt + Down Arrow in Combo box should show the drop down option box, as should F4) fixed 

However, this code is only compiled on PLATFORM(WINDOWS). We should be using it on all platforms, when OS(WINDOWS).
Comment 1 Dominic Mazzoni 2013-03-15 13:15:28 PDT
Chromium bug: http://crbug.com/1945
Comment 2 Dominic Mazzoni 2013-03-16 01:14:40 PDT
Created attachment 193426 [details]
Patch
Comment 3 WebKit Review Bot 2013-03-16 01:23:26 PDT
Comment on attachment 193426 [details]
Patch

Attachment 193426 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17114586
Comment 4 Dominic Mazzoni 2013-03-16 01:32:46 PDT
Created attachment 193428 [details]
Patch
Comment 5 WebKit Review Bot 2013-03-16 01:44:03 PDT
Comment on attachment 193428 [details]
Patch

Attachment 193428 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17184237
Comment 6 Dominic Mazzoni 2013-03-16 01:48:18 PDT
Created attachment 193431 [details]
Patch
Comment 7 Kent Tamura 2013-03-17 15:05:08 PDT
Comment on attachment 193431 [details]
Patch

ok.
Using OS() and PLATFORM() in WebCore is not nice, but they already exist in these files.
Comment 8 WebKit Review Bot 2013-03-17 23:28:06 PDT
Comment on attachment 193431 [details]
Patch

Clearing flags on attachment: 193431

Committed r146035: <http://trac.webkit.org/changeset/146035>
Comment 9 WebKit Review Bot 2013-03-17 23:28:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Review Bot 2013-03-18 01:34:24 PDT
Re-opened since this is blocked by bug 112540
Comment 11 anton muhin 2013-03-18 01:35:17 PDT
That lead to Windows debug build failures:

32>..\html\HTMLSelectElementWin.cpp(53): error C2220: warning treated as error - no 'object' file generated
32>..\html\HTMLSelectElementWin.cpp(53): warning C4018: '<' : signed/unsigned mismatch

I've reverted the patch?
Comment 12 Dominic Mazzoni 2013-03-18 09:14:23 PDT
Sorry about the build failure. That's weird, I definitely built Chromium on Windows to test this patch, so I'm not sure why I didn't see that failure. Anyway, should be easy to fix.
Comment 13 anton muhin 2013-03-18 09:17:35 PDT
(In reply to comment #12)
> Sorry about the build failure. That's weird, I definitely built Chromium on Windows to test this patch, so I'm not sure why I didn't see that failure. Anyway, should be easy to fix.

Maybe you forgot to do debug build, just wildguessing.
Comment 14 Dominic Mazzoni 2013-03-18 09:18:22 PDT
Created attachment 193579 [details]
Patch
Comment 15 Kent Tamura 2013-03-18 15:54:09 PDT
Comment on attachment 193579 [details]
Patch

ok
Comment 16 WebKit Review Bot 2013-03-18 16:13:16 PDT
Comment on attachment 193579 [details]
Patch

Clearing flags on attachment: 193579

Committed r146145: <http://trac.webkit.org/changeset/146145>
Comment 17 WebKit Review Bot 2013-03-18 16:13:20 PDT
All reviewed patches have been landed.  Closing bug.