Bug 112371 – Web Inspector: Paint rectangles shown on hover over Timeline's paint records occasionally have wrong offsets

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

1. Navigate to www.ign.com.
2. Open Web Inspector, start timeline record.
3. Reload the page.
4. Let it run for a few seconds, then stop timeline.
5. Filter paint records, hover over them.
6. Note many paint rectangles are shown at top left corner (0, 0)

This apparently happens for sub-frames.

[Andrey Kosyakov]

Created attachment 193555 [details]
Patch

[Pavel Feldman]

Comment on attachment 193555 [details]
Patch

A test?

[Andrey Kosyakov]

Created attachment 193874 [details]
Patch

[Pavel Feldman]

Comment on attachment 193874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193874&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:538
> +void InspectorInstrumentation::didPaintImpl(InstrumentingAgents*  instrumentingAgents, Frame* frame, GraphicsContext* context, const LayoutRect& rect)

Extra space here.

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:304
> +    LayoutRect rectInRootCoordinates = frame->view()->contentsToRootView(pixelSnappedIntRect(rect));

So that's the actual fix? Looks like two changes in one patch to me.

[Andrey Kosyakov]

Created attachment 194023 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 194023 [details]
Patch

A good testcase for this would test highlight rects inside an iframe which is css-transformed.

[Andrey Kosyakov]

(In reply to comment #6)
> (From update of attachment 194023 [details])
> A good testcase for this would test highlight rects inside an iframe which is css-transformed.

Thanks, but unfortunately we're not there yet -- transformed layers are off, too. I'm working on it right now, though (see bug 112919)

[Andrey Kosyakov]

Committed r146476: <http://trac.webkit.org/changeset/146476>