Bug 112250 - [V8] Pass the correct world type to V8PerIsolateData::hasInstance.
Summary: [V8] Pass the correct world type to V8PerIsolateData::hasInstance.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marja Hölttä
URL:
Keywords:
Depends on:
Blocks: 112165
  Show dependency treegraph
 
Reported: 2013-03-13 05:08 PDT by Marja Hölttä
Modified: 2013-03-19 15:43 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marja Hölttä 2013-03-13 05:08:37 PDT
Making V8PerIsolateData::hasInstance do the check according to the passed world type uncovers problems:
- v8::Handle<v8::Value> V8Document::evaluateMethodCustom(const v8::Arguments& args) seems to have the wrong node (main world instead of isolated world) in args, and HasInstance fails there. -> ExecuteScriptApiTest.ExecuteScriptFrameAfterLoad (chromium browser_tests) fails
- crash in contextHasCorrectPrototype -> ExecuteScriptApiTest.ExecuteScriptCallback (chromium browser_tests) fails.
Comment 1 Marja Hölttä 2013-03-19 15:43:52 PDT
This got done as a side effect of some other patch. We need to check multiple worlds in some cases though (if we're going through NPAPI, we don't have a context and can't get the world from there).