RESOLVED INVALID Bug 112250
[V8] Pass the correct world type to V8PerIsolateData::hasInstance. 
https://bugs.webkit.org/show_bug.cgi?id=112250
Summary [V8] Pass the correct world type to V8PerIsolateData::hasInstance.
Marja Hölttä
Reported 2013-03-13 05:08:37 PDT
Making V8PerIsolateData::hasInstance do the check according to the passed world type uncovers problems: - v8::Handle<v8::Value> V8Document::evaluateMethodCustom(const v8::Arguments& args) seems to have the wrong node (main world instead of isolated world) in args, and HasInstance fails there. -> ExecuteScriptApiTest.ExecuteScriptFrameAfterLoad (chromium browser_tests) fails - crash in contextHasCorrectPrototype -> ExecuteScriptApiTest.ExecuteScriptCallback (chromium browser_tests) fails.
Attachments
Add attachment proposed patch, testcase, etc.
Marja Hölttä
Comment 1 2013-03-19 15:43:52 PDT
This got done as a side effect of some other patch. We need to check multiple worlds in some cases though (if we're going through NPAPI, we don't have a context and can't get the world from there).
Note You need to log in before you can comment on or make changes to this bug.