Bug 112165 - [V8] Get rid of GetFromContext world type
Summary: [V8] Get rid of GetFromContext world type
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marja Hölttä
URL:
Keywords:
Depends on: 112250
Blocks: 110874
  Show dependency treegraph
 
Reported: 2013-03-12 10:34 PDT by Marja Hölttä
Modified: 2013-03-14 04:03 PDT (History)
12 users (show)

See Also:


Attachments
Patch (105.10 KB, patch)
2013-03-12 10:41 PDT, Marja Hölttä
haraken: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marja Hölttä 2013-03-12 10:34:04 PDT
It was introduced by bug 111724. We can get rid of it by passing the world type explicitly to the HasInstance functions.
Comment 1 Marja Hölttä 2013-03-12 10:41:23 PDT
Created attachment 192763 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-12 11:20:52 PDT
Comment on attachment 192763 [details]
Patch

Attachment 192763 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17138123
Comment 3 Kentaro Hara 2013-03-12 17:10:15 PDT
Comment on attachment 192763 [details]
Patch

Looks reasonable. Please fix the debug build failure before landing. (I was wondering why you had to introduce GetFromContext in the previous patch:-)
Comment 4 Marja Hölttä 2013-03-13 05:10:10 PDT
There are some newly discovered problems which prevent doing this, see bug 112250.
Comment 5 Marja Hölttä 2013-03-14 04:03:18 PDT
This is no longer needed, the new patch in bug 111724 no longer introduces this GetFromContext world type.