Bug 111959 - Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture
Summary: Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
Depends on:
Blocks: 111923
  Show dependency treegraph
Reported: 2013-03-11 01:10 PDT by jochen
Modified: 2013-03-11 18:18 PDT (History)
15 users (show)

See Also:

Patch (37.29 KB, patch)
2013-03-11 01:12 PDT, jochen
no flags Details | Formatted Diff | Diff
Patch for landing (37.34 KB, patch)
2013-03-11 14:16 PDT, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-03-11 01:10:30 PDT
Replace DefinitelyProcessingUserGesture with DefinitelyProcessingNewUserGesture
Comment 1 jochen 2013-03-11 01:12:32 PDT
Created attachment 192419 [details]
Comment 2 jochen 2013-03-11 01:15:02 PDT
Adam, what do you think about this?

Some background:

In EventHandler.cpp when processing e.g. a mouse press event, we pass on the event to a subframe's EventHandler if it wasn't handled. The subframe creates another UserGestureIndicator which currently increases the consumable gestures count.

That way, a web page can create arbitrarily many gestures by stacking iframes on top of each other.
Comment 3 jochen 2013-03-11 13:24:44 PDT
Alexey, this change touches WebKit2, can you please review it?
Comment 4 Adam Barth 2013-03-11 13:34:48 PDT
Comment on attachment 192419 [details]

Comment 5 Alexey Proskuryakov 2013-03-11 13:39:36 PDT
Comment on attachment 192419 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=192419&action=review

rs=me on WebKit2 part.

> Source/WebCore/ChangeLog:3
> +        Replace DefinitelyProcessingUserGesture with DefinitelyProcessingNewUserGesture

I'd say "rename" to make it more clear why there is no behavior change.
Comment 6 jochen 2013-03-11 14:16:42 PDT
Created attachment 192556 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-03-11 18:18:08 PDT
Comment on attachment 192556 [details]
Patch for landing

Clearing flags on attachment: 192556

Committed r145453: <http://trac.webkit.org/changeset/145453>
Comment 8 WebKit Review Bot 2013-03-11 18:18:12 PDT
All reviewed patches have been landed.  Closing bug.