Don't create multiple user gesture indicators when forwarding events to sub frames
Created attachment 192347 [details] Patch
Comment on attachment 192347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192347&action=review > Source/WebCore/page/EventHandler.cpp:3169 > + OwnPtr<UserGestureIndicator> gestureIndicator; > + > + if (!UserGestureIndicator::processingUserGesture()) > + gestureIndicator = adoptPtr(new UserGestureIndicator(DefinitelyProcessingUserGesture)); Why doesn't UserGestureIndicator do this work for us? If we're already processing a user gesture, perhaps the UserGestureIndicator shouldn't bump the count in the token... Maybe that should be an option in the constructor?
(In reply to comment #2) > (From update of attachment 192347 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192347&action=review > > > Source/WebCore/page/EventHandler.cpp:3169 > > + OwnPtr<UserGestureIndicator> gestureIndicator; > > + > > + if (!UserGestureIndicator::processingUserGesture()) > > + gestureIndicator = adoptPtr(new UserGestureIndicator(DefinitelyProcessingUserGesture)); > > Why doesn't UserGestureIndicator do this work for us? If we're already processing a user gesture, perhaps the UserGestureIndicator shouldn't bump the count in the token... Maybe that should be an option in the constructor? That's a good question. I guess that doing this by default won't work, e.g. when we run a nested message loop with a indicator on the stack during a showModalDialog() call. I need to think of a good name for an additional enum
Created attachment 192575 [details] Patch
As soon as bug 111959 is resolved, this patch will apply
Comment on attachment 192575 [details] Patch Thanks, this is much better.
Comment on attachment 192575 [details] Patch Clearing flags on attachment: 192575 Committed r145481: <http://trac.webkit.org/changeset/145481>
All reviewed patches have been landed. Closing bug.