Bug 111877 – [EFL] Use CROSS_PLATFORM_CONTEXT_MENU

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jesus Sanchez-Palencia]

EFL could easily switch to Cross platform context menu implementation and reduce the related code to this significantly.

[Jesus Sanchez-Palencia]

Created attachment 192263 [details]
Patch

[EFL EWS Bot]

Comment on attachment 192263 [details]
Patch

Attachment 192263 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17110229

[Jesus Sanchez-Palencia]

(In reply to comment #2)
> (From update of attachment 192263 [details])
> Attachment 192263 [details] did not pass efl-ews (efl):
> Output: http://webkit-commit-queue.appspot.com/results/17110229

This won't build until https://bugs.webkit.org/show_bug.cgi?id=111876 is landed.
The reason why split this into a separate patch was to avoid reviewers asking for that. :)

[Caio Marcelo de Oliveira Filho]

Comment on attachment 192263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192263&action=review

> Source/WebCore/ChangeLog:9
> +        Make EFL work with CROSS_PLATFORM_CONTEXT_MENU
> +        USE flag. This flag provides a full cross-platform

"Make EFL work with ..." kind of suggests it will still work without. I think it'll be more clear to state that now EFL uses CROSS_PLATFORM_CONTEXT_MENU.

> Source/WebCore/ChangeLog:15
> +        No new tests needed, already covered.

Which tests cover this change?

> Source/WebKit/efl/ewk/ewk_contextmenu.cpp:245
> +    const Vector<WebCore::ContextMenuItem> itemsList = coreMenu->items();

Missing "&" here. You want const Vector<...>&.

[Caio Marcelo de Oliveira Filho]

This change looks good to me after those comments are considered, but let's make EFL bot green before landing. (So probably landing your other patch first)

[Jesus Sanchez-Palencia]

Created attachment 192970 [details]
Patch

[Jesus Sanchez-Palencia]

Created attachment 193149 [details]
Patch

[WebKit Review Bot]

Comment on attachment 193149 [details]
Patch

Rejecting attachment 193149 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 193149, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
rce/WebKit/chromium/webkit/media/crypto/ppapi/cdm --revision 181763 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
58>At revision 181763.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/17126437

[Jesus Sanchez-Palencia]

Created attachment 193171 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 193171 [details]
Patch for landing

Clearing flags on attachment: 193171

Committed r145841: <http://trac.webkit.org/changeset/145841>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.