Bug 111876 - Move platform-specific typedefs to PlatformMenuDescription.h
Summary: Move platform-specific typedefs to PlatformMenuDescription.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords:
Depends on:
Blocks: 111874 111877 111882
  Show dependency tree / graph
 
Reported: 2013-03-08 11:18 PST by Jesus Sanchez-Palencia
Modified: 2013-03-14 10:40 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2013-03-08 11:52 PST, Jesus Sanchez-Palencia 		no flags Details | Formatted Diff | Diff
Patch (11.29 KB, patch)
2013-03-13 11:37 PDT, Jesus Sanchez-Palencia 		no flags Details | Formatted Diff | Diff
Patch (13.07 KB, patch)
2013-03-13 12:32 PDT, Jesus Sanchez-Palencia 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2013-03-08 11:18:16 PST 
The typedefs to NativeMenu and NativeItem fit better in PlatformMenuDescription.h, which is the header meant to this.
Comment 1 Jesus Sanchez-Palencia 2013-03-08 11:52:00 PST 
Created attachment 192259 [details]
Patch
Comment 2 Gyuyoung Kim 2013-03-10 18:39:11 PDT 
Can I ask a question ? I wonder how to implement context menu under this change. As you know, existing context menu implementation just provides APIs that application can implement context menu on EFL port. Do you have plan to change the existing context menu implementation ?

CC'ing Michal Pakula vel Rutka.
Comment 3 Jesus Sanchez-Palencia 2013-03-11 05:18:31 PDT 
(In reply to comment #2)
> Can I ask a question ? I wonder how to implement context menu under this change. As you know, existing context menu implementation just provides APIs that application can implement context menu on EFL port. Do you have plan to change the existing context menu implementation ?
> 
> CC'ing Michal Pakula vel Rutka.

I guess your question was more suit in https://bugs.webkit.org/show_bug.cgi?id=111877, right? No, this work won't change your existing context menu implementation. I'm following it closely Pakula's patches and your use-case (the application is responsible for rendering the menu and letting WebKit know about the selected item) will be kept untouched. All this USE flag does is to reduce the amount of platform-specific code in WebCore/platform/ContextMenu* files.
Comment 4 Caio Marcelo de Oliveira Filho 2013-03-12 14:25:15 PDT 
(In reply to comment #0)
> The typedefs to NativeMenu and NativeItem fit better in PlatformMenuDescription.h, which is the header meant to this.

I think they would fit better into a new file PlatformContextMenu.h, but is convenient to use the existing file. Maybe a comment to indicate that you'll rename this file once get rid of PlatformMenuDescription?

I also suggest rename the type to PlatformContextMenu, to compensate for losing the class scope you had before (ContextMenu::NativeMenu).
Comment 5 Jesus Sanchez-Palencia 2013-03-13 11:37:50 PDT 
Created attachment 192953 [details]
Patch
Comment 6 Jesus Sanchez-Palencia 2013-03-13 12:32:14 PDT 
Created attachment 192963 [details]
Patch
Comment 7 WebKit Review Bot 2013-03-14 10:40:38 PDT 
Comment on attachment 192963 [details]
Patch

Clearing flags on attachment: 192963

Committed r145827: <http://trac.webkit.org/changeset/145827>
Comment 8 WebKit Review Bot 2013-03-14 10:40:42 PDT 
All reviewed patches have been landed.  Closing bug.