Bug 111592 – fast/css/hover-update.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

webkit.org:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fcss%2Fhover-update.html

chromium.org
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcss%2Fhover-update.html

[Ryosuke Niwa]

Added a failing test expectation in http://trac.webkit.org/changeset/144944.

[Tony Chang]

*** Bug 85951 has been marked as a duplicate of this bug. ***

[Tony Chang]

*** Bug 80246 has been marked as a duplicate of this bug. ***

[Tony Chang]

Created attachment 191790 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 191790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191790&action=review

Let's try this.

> LayoutTests/fast/css/hover-update.html:31
> +    if (timeSinceStartedCheckingMs < 200 && window.getComputedStyle(document.getElementById('b'), null).backgroundColor != expectedBackgroundColor) {
> +        setTimeout(finish, 10);
> +        return;
> +    }
> +    shouldBeEqualToString("window.getComputedStyle(document.getElementById('b'), null).backgroundColor", expectedBackgroundColor);

Nit: It seems like window. is unnecessary?

[Tony Chang]

Comment on attachment 191790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191790&action=review

>> LayoutTests/fast/css/hover-update.html:31
>> +    shouldBeEqualToString("window.getComputedStyle(document.getElementById('b'), null).backgroundColor", expectedBackgroundColor);
> 
> Nit: It seems like window. is unnecessary?

Yeah, I didn't want to change the expected results which lists this string verbatim.

[Tony Chang]

Comment on attachment 191790 [details]
Patch

Actually, I can get rid of it in the 'if' above.

[Tony Chang]

Created attachment 191805 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 191805 [details]
Patch for landing

Clearing flags on attachment: 191805

Committed r144963: <http://trac.webkit.org/changeset/144963>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.