Bug 111441 – Cache flush problem on ARMv7 JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gabor Rapcsanyi]

The ARMv7 random crash problem is caused by cache flushing. https://bugs.webkit.org/show_bug.cgi?id=108632 just hide the real bug.

The problem is similar to this bug:
https://bugs.webkit.org/show_bug.cgi?id=77712

After changing the cache flush mechanism in ARMv7 to ARM traditional the problem has gone.

[Csaba Osztrogonác]

*** Bug 108632 has been marked as a duplicate of this bug. ***

[Csaba Osztrogonác]

Could you revert Simon's workaround ( http://trac.webkit.org/changeset/144170 ) after or with this patch?

[Gabor Rapcsanyi]

Created attachment 191737 [details]
proposed fix

In another patch we should make it more sophisticated but for now it solves the problem.
I'm also reverting Simon's patch with this.

[Csaba Osztrogonác]

Yay, with this patch there are only 171 remaining inspector crashes on Thumb2,
but they are unrelated to this bug - http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7987

[Zoltan Herczeg]

Comment on attachment 191737 [details]
proposed fix

r=me.

But I think the current flush mechanism invalidates a large amount of unnecessary, so we should improve with it.

[WebKit Review Bot]

Comment on attachment 191737 [details]
proposed fix

Clearing flags on attachment: 191737

Committed r145194: <http://trac.webkit.org/changeset/145194>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.