Bug 111436 - Fix cast-align warning in ASCIIFastPath.h on ARM
Summary: Fix cast-align warning in ASCIIFastPath.h on ARM
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Blocks: 108645
  Show dependency treegraph
Reported: 2013-03-05 06:48 PST by Csaba Osztrogonác
Modified: 2013-03-05 13:43 PST (History)
8 users (show)

See Also:

Patch (1.53 KB, patch)
2013-03-05 06:50 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-03-05 06:48:32 PST
ASCIIFastPath.h introduced in https://trac.webkit.org/changeset/104127 ,
but on ARM we get zillion warning from it:

/home/webkitbuildbot/oszi/WebKitNix/Source/WTF/wtf/text/ASCIIFastPath.h: In instantiation of 'bool WTF::charactersAreAllASCII(const CharacterType*, size_t) [with CharacterType = short unsigned int; size_t = unsigned int]':
/home/webkitbuildbot/oszi/WebKitNix/Source/WTF/wtf/text/WTFString.h:606:66:   required from here
/home/webkitbuildbot/oszi/WebKitNix/Source/WTF/wtf/text/ASCIIFastPath.h:88:9: warning: cast from 'const short unsigned int*' to 'const MachineWord* {aka const unsigned int*}' increases required alignment of target type [-Wcast-align]

This cast is safe, because the adress is aligned here. Patch is coming soon.

( Similar fixes:
- https://trac.webkit.org/changeset/67028
- https://trac.webkit.org/changeset/64302 )
Comment 1 Csaba Osztrogonác 2013-03-05 06:50:16 PST
Created attachment 191489 [details]
Comment 2 WebKit Review Bot 2013-03-05 13:43:28 PST
Comment on attachment 191489 [details]

Clearing flags on attachment: 191489

Committed r144811: <http://trac.webkit.org/changeset/144811>
Comment 3 WebKit Review Bot 2013-03-05 13:43:31 PST
All reviewed patches have been landed.  Closing bug.