Bug 111433 – Fix unused parameter warnings in ARM assembler

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

SSIA. Patch is coming soon.

[Csaba Osztrogonác]

Created attachment 191486 [details]
Patch

[Kentaro Hara]

Comment on attachment 191486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191486&action=review

> Source/JavaScriptCore/assembler/ARMAssembler.h:407
>          static void revertJump(void* instructionStart, RegisterID rd, ARMWord imm)
>          {
> +            UNUSED_PARAM(rd);

You can remove the parameter name if there is no confusion. If the parameter name is needed for clarity, you can comment the parameter name. We use UNUSED_PARAM() only in an #if block.

c.f. http://markmail.org/message/jv3ncbuhropkkzoq

[Csaba Osztrogonác]

Created attachment 191763 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #2)
> You can remove the parameter name if there is no confusion. If the parameter name is needed for clarity, you can comment the parameter name. We use UNUSED_PARAM() only in an #if block.
> 
> c.f. http://markmail.org/message/jv3ncbuhropkkzoq

Good point, I didn't remember this mail thread. But now I fixed
the patch, remove the first function which is unreachable and
changed one more older, but incorrect use of UNUSED_PARAM.

[WebKit Review Bot]

Comment on attachment 191763 [details]
Patch

Clearing flags on attachment: 191763

Committed r144938: <http://trac.webkit.org/changeset/144938>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.