Bug 111107 – Add private API to disable WKView window occlusion detection

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kiran Muppala]

https://bugs.webkit.org/show_bug.cgi?id=107494, added window occlusion detection support to WKView, which caused some javascript timer related layout tests to fail using WebKitTestRunner.  I submitted a initial fix that just initializes the page visibility in WebKitTestRunner, https://bugs.webkit.org/show_bug.cgi?id=111025, but that still opens the door for other tests to fail if they depend on the view to know it is visible.

Hence, adding a private API to disable window occlusion detection will allow a more robust fix for WebKitTestRunner issues with window occlusion.

[Kiran Muppala]

<rdar://problem/13211598>

[Kiran Muppala]

Created attachment 190803 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 190803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190803&action=review

> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63
> +- (void)disableWindowOcclusionDetection;
> +- (void)enableWindowOcclusionDetection;

Normally we'd do this like setWindowOcclustionDetectionEnabled:(BOOL)

[Kiran Muppala]

Created attachment 190808 [details]
Patch

[Kiran Muppala]

(In reply to comment #3)
> (From update of attachment 190803 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190803&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63
> > +- (void)disableWindowOcclusionDetection;
> > +- (void)enableWindowOcclusionDetection;
> 
> Normally we'd do this like setWindowOcclustionDetectionEnabled:(BOOL)

Got it.  I replaced the two methods with a single setter.

[WebKit Review Bot]

Comment on attachment 190808 [details]
Patch

Clearing flags on attachment: 190808

Committed r144389: <http://trac.webkit.org/changeset/144389>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.