Bug 111107 - Add private API to disable WKView window occlusion detection
Summary: Add private API to disable WKView window occlusion detection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kiran Muppala
URL:
Keywords: InRadar
Depends on:
Blocks: 111116
  Show dependency tree / graph
 
Reported: 2013-02-28 13:31 PST by Kiran Muppala
Modified: 2013-02-28 16:01 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2013-02-28 14:00 PST, Kiran Muppala 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2013-02-28 14:27 PST, Kiran Muppala 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kiran Muppala 2013-02-28 13:31:06 PST 
https://bugs.webkit.org/show_bug.cgi?id=107494, added window occlusion detection support to WKView, which caused some javascript timer related layout tests to fail using WebKitTestRunner.  I submitted a initial fix that just initializes the page visibility in WebKitTestRunner, https://bugs.webkit.org/show_bug.cgi?id=111025, but that still opens the door for other tests to fail if they depend on the view to know it is visible.

Hence, adding a private API to disable window occlusion detection will allow a more robust fix for WebKitTestRunner issues with window occlusion.
Comment 1 Kiran Muppala 2013-02-28 13:31:22 PST 
<rdar://problem/13211598>
Comment 2 Kiran Muppala 2013-02-28 14:00:45 PST 
Created attachment 190803 [details]
Patch
Comment 3 Simon Fraser (smfr) 2013-02-28 14:04:23 PST 
Comment on attachment 190803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190803&action=review

> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63
> +- (void)disableWindowOcclusionDetection;
> +- (void)enableWindowOcclusionDetection;

Normally we'd do this like setWindowOcclustionDetectionEnabled:(BOOL)
Comment 4 Kiran Muppala 2013-02-28 14:27:37 PST 
Created attachment 190808 [details]
Patch
Comment 5 Kiran Muppala 2013-02-28 14:30:52 PST 
(In reply to comment #3)
> (From update of attachment 190803 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190803&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63
> > +- (void)disableWindowOcclusionDetection;
> > +- (void)enableWindowOcclusionDetection;
> 
> Normally we'd do this like setWindowOcclustionDetectionEnabled:(BOOL)

Got it.  I replaced the two methods with a single setter.
Comment 6 WebKit Review Bot 2013-02-28 16:01:08 PST 
Comment on attachment 190808 [details]
Patch

Clearing flags on attachment: 190808

Committed r144389: <http://trac.webkit.org/changeset/144389>
Comment 7 WebKit Review Bot 2013-02-28 16:01:11 PST 
All reviewed patches have been landed.  Closing bug.