Bug 111025 – Initialize page visibility after creating WebKitTestRunner WebView on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kiran Muppala]

Window Occlusion Notifications on Mac mark the WebKitTestRunner's WebView as not visible as soon as created.  On Mac this enables JavaScript timer throttling and hence causes the following layouts tests to fail.

fast/dom/timer-increase-min-interval-and-reset-part-2.html
fast/dom/timer-increase-then-decrease-min-interval-repeating.html
fast/dom/timer-increase-then-decrease-min-interval.html	
fast/dom/timer-throttling-hidden-page.html

So, to avoid issues due to the page being marked as hidden, WebKitTestRunner should initialize the page visibility to "visible" after creating the WebView.

[Kiran Muppala]

<rdar://problem/13305561>

[Kiran Muppala]

https://bugs.webkit.org/show_bug.cgi?id=107494

[Kiran Muppala]

(In reply to comment #2)
> https://bugs.webkit.org/show_bug.cgi?id=107494

Link to bug which added window occlusion notifications.

[Kiran Muppala]

Created attachment 190628 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 190628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190628&action=review

Does DRT also need fixing?

> Tools/WebKitTestRunner/TestController.cpp:487
> +    setVisibilityState(kWKPageVisibilityStateVisible, true);

Hard to know what the 'true' means reading this.

[WebKit Review Bot]

Comment on attachment 190628 [details]
Patch

Clearing flags on attachment: 190628

Committed r144259: <http://trac.webkit.org/changeset/144259>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kiran Muppala]

(In reply to comment #5)
> (From update of attachment 190628 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190628&action=review
> 
> Does DRT also need fixing?
> 
Not currently because window occlusion notifications are only available in WebKit2.

> > Tools/WebKitTestRunner/TestController.cpp:487
> > +    setVisibilityState(kWKPageVisibilityStateVisible, true);
> 
> Hard to know what the 'true' means reading this.

I considered adding a inline comment /*isInitialState*/, but then in a previous WebKit2 patch that style was frowned upon.  I can find several such instances of inline comment in WebCore but just one in WebKit2.  So, I left it out.