RESOLVED INVALID 110908
[GTK] Add libsecret package to jhbuild modules. 
https://bugs.webkit.org/show_bug.cgi?id=110908
Summary [GTK] Add libsecret package to jhbuild modules.
Tullio Lucena
Reported 2013-02-26 13:33:23 PST
The libsecret package wasn't being loaded into jhbuild modules by default.
Attachments
Patch (1.03 KB, patch)
2013-02-26 13:39 PST, Tullio Lucena 		mrobinson: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tullio Lucena
Comment 1 2013-02-26 13:39:04 PST
Created attachment 190352 [details] Patch
Martin Robinson
Comment 2 2013-02-26 14:18:38 PST
Comment on attachment 190352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190352&action=review > Tools/gtk/jhbuild.modules:30 > + <dep package="libsecret"/> Did you take a look at the bug ( https://bugs.webkit.org/show_bug.cgi?id=109195 ) ? The purpose of the modules in jhbuild-optional is that they are optional. The modules installed by default are ones in which having the exact version is required for layout tests to pass. libsecret doesn't fall into this category and making it non-optional means that everyone has to build it, even when they don't need to.
Tullio Lucena
Comment 3 2013-02-27 10:23:29 PST
You are right. It was a problem with my SO (Ubuntu 12.04). Sorry, and thanks for the help.
Martin Robinson
Comment 4 2013-02-27 10:26:28 PST
(In reply to comment #3) > You are right. > It was a problem with my SO (Ubuntu 12.04). > Sorry, and thanks for the help. Oh, I should have mentioned that you can install libsecret by doing: ./Tools/jhbuild/jhbuild-wrapper --gtk buildone libsecret
Note You need to log in before you can comment on or make changes to this bug.