This allows people to build on distributions like Ubuntu Precise without installing anything outside the jhbuild.
Created attachment 187366 [details]
Comment on attachment 187366 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=187366&action=review
It looks good but please remove the gyp stuff, which I think is unrelated to this patch ;)
> + * WTF.gyp/WTF.gyp: Filter out MetaAllocator.(cpp/h) from the Chromium
> + build. It's only necessary for GTK+.
> + * WTF.gypi: Add MetaAllocator to the build for WebKitGTK+.
Is this really related with the scope of this patch?
> + jsc, and minidom build (and only on platforms for that support bash). To use the
> + build simply run:
Hum, ditto :) Looks like some ChangeLog entries belong to another bug.
Ok I guess this is unrelated as well
> +#ifdef HAVE_LIBSECRET
Perhaps that could be #if HAVE(LIBSECRET) ?
Retargeting this bug a bit. Instead of making libsecret optional, it makes sense to add some hard-to-get packages to the jhbuild setup that are just not installed by default.
Created attachment 187764 [details]
Comment on attachment 187764 [details]
Clearing flags on attachment: 187764
Committed r142620: <http://trac.webkit.org/changeset/142620>
All reviewed patches have been landed. Closing bug.
*** Bug 101813 has been marked as a duplicate of this bug. ***
*** Bug 101594 has been marked as a duplicate of this bug. ***