Bug 110784 - 6% regression in intl1 page cycler on chromium-mac
Summary: 6% regression in intl1 page cycler on chromium-mac
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 109888
  Show dependency tree / graph
 
Reported: 2013-02-25 12:44 PST by Adam Barth
Modified: 2013-04-08 16:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (19.85 KB, patch)
2013-02-25 12:45 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (9.70 KB, patch)
2013-02-25 16:09 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (29.91 KB, patch)
2013-02-25 23:08 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-02-25 12:44:18 PST 
6% regression in intl1 page cycler on chromium-mac
Comment 1 Adam Barth 2013-02-25 12:45:38 PST 
Created attachment 190107 [details]
Patch
Comment 3 Eric Seidel (no email) 2013-02-25 12:46:53 PST 
Comment on attachment 190107 [details]
Patch

Lets give it a whirl.
Comment 4 Adam Barth 2013-02-25 13:00:08 PST 
Comment on attachment 190107 [details]
Patch

Clearing flags on attachment: 190107

Committed r143960: <http://trac.webkit.org/changeset/143960>
Comment 5 Adam Barth 2013-02-25 13:00:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Adam Barth 2013-02-25 13:00:28 PST 
Re-opening to watch the perf graph.
Comment 7 Adam Barth 2013-02-25 14:50:33 PST 
Does not appear to have healed the bot.  Will wait for a couple more cycles to verify.
Comment 8 Adam Barth 2013-02-25 16:08:06 PST 
I'm going to attempt a rollout of http://trac.webkit.org/changeset/143014 next.  If that doesn't heal the bot, I'll roll it back in.
Comment 9 Adam Barth 2013-02-25 16:09:38 PST 
Created attachment 190148 [details]
Patch
Comment 10 Eric Seidel (no email) 2013-02-25 16:10:53 PST 
Comment on attachment 190148 [details]
Patch

kling would be the best reviewer.  But this looks like a proper revert.
Comment 11 Adam Barth 2013-02-25 16:14:34 PST 
Comment on attachment 190148 [details]
Patch

Clearing flags on attachment: 190148

Committed r143983: <http://trac.webkit.org/changeset/143983>
Comment 12 Adam Barth 2013-02-25 16:14:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Adam Barth 2013-02-25 16:14:54 PST 
Re-opening to watch the perf graph.
Comment 14 Adam Barth 2013-02-25 18:39:49 PST 
Reverting the patch seems to have healed the bot, but we should wait for a few more cycles to confirm.
Comment 15 Adam Barth 2013-02-25 22:34:57 PST 
The bot has not been healed.
Comment 16 Adam Barth 2013-02-25 23:08:24 PST 
Created attachment 190213 [details]
Patch
Comment 17 Eric Seidel (no email) 2013-02-25 23:10:22 PST 
Comment on attachment 190213 [details]
Patch

One might argue we should roll these back in separately, but OK.
Comment 18 Adam Barth 2013-02-25 23:22:24 PST 
> One might argue we should roll these back in separately, but OK.

Hum...  Yeah, sorry I already kicked off the script.
Comment 19 Adam Barth 2013-02-25 23:23:33 PST 
Comment on attachment 190213 [details]
Patch

Clearing flags on attachment: 190213

Committed r144010: <http://trac.webkit.org/changeset/144010>
Comment 20 Adam Barth 2013-02-25 23:23:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 21 Adam Barth 2013-02-25 23:24:15 PST 
Still not fixed.