Bug 109888 - ElementData: Move leafy things out of the base class.
Summary: ElementData: Move leafy things out of the base class.
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on: 110784
Blocks: 109505
  Show dependency treegraph
Reported: 2013-02-14 22:02 PST by Andreas Kling
Modified: 2013-02-26 00:30 PST (History)
5 users (show)

See Also:

Patch (10.18 KB, patch)
2013-02-14 22:05 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-02-14 22:02:06 PST
We should move stuff from ElementData to UniqueElementData or ShareableElementData where it makes sense.
Comment 1 Andreas Kling 2013-02-14 22:05:19 PST
Created attachment 188479 [details]
Comment 2 WebKit Review Bot 2013-02-15 10:29:54 PST
Comment on attachment 188479 [details]

Clearing flags on attachment: 188479

Committed r143014: <http://trac.webkit.org/changeset/143014>
Comment 3 WebKit Review Bot 2013-02-15 10:29:58 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Andreas Kling 2013-02-15 14:44:29 PST
(In reply to comment #4)
> Hello, this broke the Windows build.
> http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44333/steps/compile-webkit/logs/stdio

Oops! Looks like it was bug 109959. I'll roll that out for now. Whatever happened to the win ews builder?
Comment 6 Adam Barth 2013-02-25 16:18:49 PST
We're checking whether this patch caused a performance regression in bug 110784.
Comment 7 Adam Barth 2013-02-26 00:30:47 PST
Sorry for the noise.  This patch was not the problem.  I've re-landed it.