Bug 110758 – REGRESSION(r143895): broke a bunch of tests (Requested by thakis__ on #webkit).

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/143895 broke the build:
broke a bunch of tests (Requested by thakis__ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 190058 [details]
ROLLOUT of r143895

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Nico Weber]

Some of this, not sure if that's normal (looks unrelated at least):

Starting 4 workers ...
Failed to run PrettyPatch (('ruby', '-I', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch\\prettify.rb', 'E:\\b\\chromium-win-release-tests\\build\\layout-test-results\\canvas/philip/tests/2d.composite.operation.clear-diff.txt')):
Failed to run "('ruby', '-I', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch\\prettify.rb', 'E:\\b\\chromium-win-release-tests\\build\\layout-test-results\\canvas/philip/tests/2d.composite.operation.clear-diff.txt')" exit_code: 1

Last 500 characters of output:
uild/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:130:in `encode': code converter not found (UTF-8 to UTF-16) (Encoding::ConverterNotFoundError)
	from E:/b/chromium-win-release-tests/build/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:130:in `normalize_line_ending'
	from E:/b/chromium-win-release-tests/build/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:18:in `prettify'
	from E:/b/chromium-win-release-tests/build/Websites/bugs.webkit.org/PrettyPatch/prettify.rb:30:in `<main>'
Failed to run PrettyPatch (('ruby', '-I', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch\\prettify.rb', 'E:\\b\\chromium-win-release-tests\\build\\layout-test-results\\http/tests/cache/cached-main-resource-diff.txt')):
Failed to run "('ruby', '-I', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch\\prettify.rb', 'E:\\b\\chromium-win-release-tests\\build\\layout-test-results\\http/tests/cache/cached-main-resource-diff.txt')" exit_code: 1




And also, lots of timeouts (in return, also some unexpected passes)


http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34570/steps/layout-test/logs/stdio


Expected to crash, but passed: (1)
  media/video-error-does-not-exist.html

Expected to timeout, but passed: (1)
  fast/css-grid-layout/grid-preferred-logical-widths.html

Expected to fail, but passed: (24)
  animations/fill-mode-iteration-count-non-integer.html
  canvas/philip/tests/2d.gradient.interpolate.colouralpha.html
  compositing/color-matching/image-color-matching.html
  compositing/visibility/visibility-image-layers.html
  css3/selectors3/xhtml/css3-modsel-15c.xml
  fast/backgrounds/background-opaque-clipped-gradients.html
  fast/backgrounds/background-opaque-images-over-color.html
  fast/backgrounds/gradient-background-shadow.html
  fast/borders/fieldsetBorderRadius.html
  fast/css/font-face-download-error.html
  fast/filesystem/op-restricted-names.html
  fast/js/cross-frame-bad-time.html
  fast/multicol/newmulticol/column-rules-fixed-height.html
  fast/regions/seamless-iframe-flowed-into-regions.html
  fast/sub-pixel/transformed-iframe-copy-on-scroll.html
  http/tests/misc/favicon-loads-with-images-disabled.html
  media/audio-controls-rendering.html
  media/controls-after-reload.html
  media/controls-strict.html
  media/controls-styling-strict.html
  media/controls-without-preload.html
  media/track/track-cue-rendering-horizontal.html
  media/video-controls-rendering.html
  media/video-playing-and-pause.html


Regressions: Unexpected text-only failures (3)
  inspector/audits/audits-panel-functional.html [ Failure ]
  inspector/extensions/extensions-resources.html [ Failure ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key.html [ Failure ]

Regressions: Unexpected timeouts (20)
  fast/css-grid-layout/grid-auto-flow-resolution.html [ Timeout ]
  html5lib/run-test16.html [ Timeout ]
  http/tests/security/no-referrer.html [ Timeout ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ Timeout ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ Timeout ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html [ Timeout ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html [ Timeout ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html [ Timeout ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html [ Timeout ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html [ Timeout ]
  platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal.html [ Timeout ]
  platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html [ Timeout ]
  platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html [ Timeout ]
  platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html [ Timeout ]
  platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html [ Timeout ]
  platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html [ Timeout ]
  platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html [ Timeout ]
  platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html [ Timeout ]
  platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html [ Timeout ]
  platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html [ Timeout ]


22242 tests ran as expected, 5492 didn't:

Failed to execute Tools\Scripts\new-run-webkit-tests at ./Tools/Scripts/run-webkit-tests line 106.

[WebKit Review Bot]

Comment on attachment 190058 [details]
ROLLOUT of r143895

Clearing flags on attachment: 190058

Committed r143924: <http://trac.webkit.org/changeset/143924>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dirk Pranke]

I think the prettypatch failures are unrelated. 

The timeouts are odd; last I checked I wasn't seeing these locally. I'll have to try again.

[Nico Weber]

Hm, maybe I reverted prematurely. 

http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34570 has the timeouts.

http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34571 doesn't but it still uses ninja.

Maybe I'll just try again tomorrow.

[Dirk Pranke]

Maybe I'll flip the switch again this afternoon and give it a shot.

[Nico Weber]

Sounds good!

As of http://trac.webkit.org/changeset/143951 , flipping the switch back even works somewhat reliably ;-) (webkit.vcxproj also isn't written on _every_ change, but in practice on most)

[Dirk Pranke]

Reverted r143924 for reason:

try ninja again

Committed r143978: <http://trac.webkit.org/changeset/143978>