Bug 110731 - Make ninja the default build system for build-webkit --chromium on windows
Summary: Make ninja the default build system for build-webkit --chromium on windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on: 110758
Blocks: 104434
  Show dependency treegraph
 
Reported: 2013-02-25 00:50 PST by Nico Weber
Modified: 2013-02-25 19:06 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.14 KB, patch)
2013-02-25 00:51 PST, Nico Weber
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2013-02-25 00:50:35 PST
Make ninja the default build system for build-webkit --chromium on windows
Comment 1 Nico Weber 2013-02-25 00:51:32 PST
Created attachment 190014 [details]
Patch
Comment 2 jochen 2013-02-25 00:53:42 PST
Comment on attachment 190014 [details]
Patch

ok
Comment 3 Nico Weber 2013-02-25 01:34:25 PST
Comment on attachment 190014 [details]
Patch

Thanks! Let's see what breaks.
Comment 4 WebKit Review Bot 2013-02-25 01:50:35 PST
Comment on attachment 190014 [details]
Patch

Clearing flags on attachment: 190014

Committed r143895: <http://trac.webkit.org/changeset/143895>
Comment 5 WebKit Review Bot 2013-02-25 01:50:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2013-02-25 07:38:13 PST
Re-opened since this is blocked by bug 110758
Comment 7 Dirk Pranke 2013-02-25 15:07:09 PST
trying again ... reenabled in http://trac.webkit.org/changeset/143978
Comment 8 Dirk Pranke 2013-02-25 19:06:24 PST
seems to be happy so far w/ ~5 runs all greenish.