Bug 110698 – getPropertyValue for -webkit-column-rule returns null, should compute the shorthand value

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Uday Kiran]

style.getPropertyValue("-webkit-column-rule") returns null.

[Uday Kiran]

Created attachment 189940 [details]
Proposed Patch

[Uday Kiran]

Created attachment 189941 [details]
Proposed Patch

Fixed a typo in bug title.

[Alexander Pavlov (apavlov)]

Comment on attachment 189940 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189940&action=review

> LayoutTests/fast/css/getPropertyValue-column-rule.html:24
> +  <div id="-webkit-column-rule7" class="test" style="-webkit-column-rule: green;"></div>

Would you mind adding an invalid property value case ("-webkit-column-rule: foo" should work, I guess), along with some cases that implicitly specify the shorthand value by setting values of the respective longhands?

[Uday Kiran]

Created attachment 190090 [details]
Updated Patch

Added testcases.

[Uday Kiran]

(In reply to comment #3)
> (From update of attachment 189940 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189940&action=review
> 
> > LayoutTests/fast/css/getPropertyValue-column-rule.html:24
> > +  <div id="-webkit-column-rule7" class="test" style="-webkit-column-rule: green;"></div>
> 
> Would you mind adding an invalid property value case ("-webkit-column-rule: foo" should work, I guess),
returns null on firefox 22 and IE10

> along with some cases that implicitly specify the shorthand value by setting values of the respective longhands?

Added.
If only few longhand properties are specified, getPropertyValue for shorthand property returns null in Firefox and IE10.

[Alexander Pavlov (apavlov)]

Comment on attachment 190090 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190090&action=review

Please fix one minor nit, and we are good to land!

Please note that this patch will most likely conflict with your other patch for bug 110816, so you will need to rebase the one whichever lands last for the commit-queue to be able to process it.

> LayoutTests/fast/css/getPropertyValue-column-rule.html:71
> +    </script>

This should be unindented 2 spaces, in line with the following <script src=...></script>

[Uday Kiran]

Created attachment 190321 [details]
Updated Patch

Fixed Indentation.

[Alexander Pavlov (apavlov)]

Comment on attachment 190321 [details]
Updated Patch

r=me

[WebKit Review Bot]

Comment on attachment 190321 [details]
Updated Patch

Clearing flags on attachment: 190321

Committed r144146: <http://trac.webkit.org/changeset/144146>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Sergey Ryazanov]

Reopening to attach new patch.

[Sergey Ryazanov]

Created attachment 190445 [details]
Patch

[Build Bot]

Comment on attachment 190445 [details]
Patch

Attachment 190445 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16798068

[Sergey Ryazanov]

Created attachment 190451 [details]
My patch accidentally uploaded into a wrong bug. Returning the right patch.