Bug 110816 - getPropertyValue for -webkit-marquee returns null, should compute the shorthand value
Summary: getPropertyValue for -webkit-marquee returns null, should compute the shortha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 103244
  Show dependency tree / graph
 
Reported: 2013-02-25 16:00 PST by Uday Kiran
Modified: 2013-02-27 15:21 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.43 KB, patch)
2013-02-25 16:16 PST, Uday Kiran 		no flags Details | Formatted Diff | Diff
Patch (7.68 KB, patch)
2013-02-26 10:05 PST, Uday Kiran 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uday Kiran 2013-02-25 16:00:47 PST 
style.getPropertyValue("-webkit-marquee") shorthand returns null
Comment 1 Uday Kiran 2013-02-25 16:16:56 PST 
Created attachment 190151 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-02-25 22:01:55 PST 
Comment on attachment 190151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190151&action=review

> LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:3
> +<head>

It is a good idea to use proper tag indentation inside the <html> to enhance readability. Even one space will work, like in getPropertyValue-border.html

> LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:36
> +description("<a href=\"https://bugs.webkit.org/show_bug.cgi?id=110816\">Bug 110816: getPropertyValue for -webkit-marquee returns null, should compute the shorthand value</a>");

The code inside <script> should also be indented relative to the <script> tag.

> LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:38
> +function testWebkitMarquee(id) {

This does not actually test the property but returns its value. I believe "webkitMarqueeValue" will work as a new name.
Comment 3 Uday Kiran 2013-02-26 10:05:39 PST 
Created attachment 190319 [details]
Patch

Fixed indentation.
Comment 4 Alexander Pavlov (apavlov) 2013-02-26 21:56:43 PST 
Comment on attachment 190319 [details]
Patch

r=me
Comment 5 WebKit Review Bot 2013-02-26 22:08:25 PST 
Comment on attachment 190319 [details]
Patch

Clearing flags on attachment: 190319

Committed r144144: <http://trac.webkit.org/changeset/144144>
Comment 6 WebKit Review Bot 2013-02-26 22:08:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Uday Kiran 2013-02-27 15:21:03 PST 
Thanks for review and cq+.