Bug 110438 - [WK2][EFL] Clean up PageViewportControllerClientEfl class
Summary: [WK2][EFL] Clean up PageViewportControllerClientEfl class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 107657
  Show dependency treegraph
 
Reported: 2013-02-21 01:14 PST by Mikhail Pozdnyakov
Modified: 2013-02-22 01:35 PST (History)
7 users (show)

See Also:


Attachments
patch (7.17 KB, patch)
2013-02-21 02:07 PST, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
patch v2 (7.24 KB, patch)
2013-02-21 04:51 PST, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2013-02-21 01:14:15 PST
PageViewportControllerClientEfl contains surprisingly a lot of methods and members which: 1) useless 2) accessing WK2 internals.
Comment 1 Mikhail Pozdnyakov 2013-02-21 02:07:15 PST
Created attachment 189482 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2013-02-21 03:52:58 PST
Comment on attachment 189482 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189482&action=review

LGTM

> Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.h:46
> +    void setViewportPosition(const WebCore::FloatPoint&);

OVERRIDE? is are they not?

> Source/WebKit2/UIProcess/efl/WebView.cpp:159
> +        FloatSize size = m_ewkView->size();
> +        // The viewport controller expects sizes in UI units, and not raw device units.
> +        size.scale(1 / m_page->deviceScaleFactor());

cant that be one line? doesnt scale return a size?
Comment 3 Mikhail Pozdnyakov 2013-02-21 04:21:29 PST
(In reply to comment #2)
> (From update of attachment 189482 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189482&action=review
> 
> LGTM
> 
> > Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.h:46
> > +    void setViewportPosition(const WebCore::FloatPoint&);
> 
> OVERRIDE? is are they not?
yeah, I'll add it.

> 
> > Source/WebKit2/UIProcess/efl/WebView.cpp:159
> > +        FloatSize size = m_ewkView->size();
> > +        // The viewport controller expects sizes in UI units, and not raw device units.
> > +        size.scale(1 / m_page->deviceScaleFactor());
> 
> cant that be one line? doesnt scale return a size?
Unfortunately not :/
Comment 4 Mikhail Pozdnyakov 2013-02-21 04:51:51 PST
Created attachment 189510 [details]
patch v2

Took comments from Kenneth into consideration.
Comment 5 Kenneth Rohde Christiansen 2013-02-22 01:25:28 PST
Comment on attachment 189510 [details]
patch v2

LGTM
Comment 6 WebKit Review Bot 2013-02-22 01:35:38 PST
Comment on attachment 189510 [details]
patch v2

Clearing flags on attachment: 189510

Committed r143705: <http://trac.webkit.org/changeset/143705>
Comment 7 WebKit Review Bot 2013-02-22 01:35:43 PST
All reviewed patches have been landed.  Closing bug.