PageViewportControllerClientEfl contains surprisingly a lot of methods and members which: 1) useless 2) accessing WK2 internals.
Created attachment 189482 [details] patch
Comment on attachment 189482 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=189482&action=review LGTM > Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.h:46 > + void setViewportPosition(const WebCore::FloatPoint&); OVERRIDE? is are they not? > Source/WebKit2/UIProcess/efl/WebView.cpp:159 > + FloatSize size = m_ewkView->size(); > + // The viewport controller expects sizes in UI units, and not raw device units. > + size.scale(1 / m_page->deviceScaleFactor()); cant that be one line? doesnt scale return a size?
(In reply to comment #2) > (From update of attachment 189482 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189482&action=review > > LGTM > > > Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.h:46 > > + void setViewportPosition(const WebCore::FloatPoint&); > > OVERRIDE? is are they not? yeah, I'll add it. > > > Source/WebKit2/UIProcess/efl/WebView.cpp:159 > > + FloatSize size = m_ewkView->size(); > > + // The viewport controller expects sizes in UI units, and not raw device units. > > + size.scale(1 / m_page->deviceScaleFactor()); > > cant that be one line? doesnt scale return a size? Unfortunately not :/
Created attachment 189510 [details] patch v2 Took comments from Kenneth into consideration.
Comment on attachment 189510 [details] patch v2 LGTM
Comment on attachment 189510 [details] patch v2 Clearing flags on attachment: 189510 Committed r143705: <http://trac.webkit.org/changeset/143705>
All reviewed patches have been landed. Closing bug.