Bug 110130 - Web Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls
Summary: Web Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks: 110227
  Show dependency treegraph
 
Reported: 2013-02-18 09:14 PST by Andrey Adaikin
Modified: 2013-02-19 08:34 PST (History)
8 users (show)

See Also:


Attachments
Patch (12.81 KB, patch)
2013-02-18 09:19 PST, Andrey Adaikin
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-02-18 09:14:54 PST
Use timeline's didBeginFrame for marking frame end calls instead of an ad-hoc timeout-based solution.

Patch to follow.
Comment 1 Andrey Adaikin 2013-02-18 09:19:12 PST
Created attachment 188902 [details]
Patch
Comment 2 Andrey Adaikin 2013-02-19 07:15:30 PST
Committed r143328: <http://trac.webkit.org/changeset/143328>
Comment 3 Andrey Adaikin 2013-02-19 08:34:33 PST
This patch broke Win Debug Build:

7>   Creating library C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\WebKit.lib and object C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\WebKit.exp
7>WebCore.lib(InspectorController.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::InspectorCanvasAgent::didBeginFrame(void)" (?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ)
7>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin\WebKit.dll : fatal error LNK1120: 1 unresolved externals
7>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\obj\WebKitLib\BuildLog.htm"
7>WebKitLib - 2 error(s), 1 warning(s)

Patch with the fix is on the way: https://bugs.webkit.org/show_bug.cgi?id=110227