Bug 110227 - Web Inspector: follow up to r143328 fixing Win Debug Build
Summary: Web Inspector: follow up to r143328 fixing Win Debug Build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on: 110130 110301
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-19 08:33 PST by Andrey Adaikin
Modified: 2013-02-19 22:01 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2013-02-19 08:36 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Reverting, try bots (1.42 KB, patch)
2013-02-19 21:16 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-02-19 08:33:09 PST 
Patch to follow.
Comment 1 Andrey Adaikin 2013-02-19 08:36:12 PST 
Created attachment 189095 [details]
Patch
Comment 2 Pavel Feldman 2013-02-19 08:37:17 PST 
Comment on attachment 189095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189095&action=review

> Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in:125
> +        ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ

InspectorCanvas should not be exposed to the WebKit, why is it needed here?
Comment 3 Andrey Adaikin 2013-02-19 08:56:46 PST 
Manually committed r143338: <http://trac.webkit.org/changeset/143338>
Comment 4 Andrey Adaikin 2013-02-19 21:16:22 PST 
Reopening to attach new patch.
Comment 5 Andrey Adaikin 2013-02-19 21:16:25 PST 
Created attachment 189231 [details]
Reverting, try bots