Bug 110002 - Add WebKitCSSMatrix to FeatureObserver
Summary: Add WebKitCSSMatrix to FeatureObserver
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks: 110001
  Show dependency treegraph
 
Reported: 2013-02-15 20:32 PST by Dirk Schulze
Modified: 2014-04-05 14:11 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.29 KB, patch)
2013-02-15 20:39 PST, Dirk Schulze
abarth: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2013-02-15 20:32:37 PST
At some point we want to introduce a new API for matrices and deprecate WebKitCSSMatrix.

WebKitCSSMatrix is not used anywhere within WebCore. So it is probably not used in the web either. Add the interface to the observer to verify this.
Comment 1 Dirk Schulze 2013-02-15 20:39:12 PST
Created attachment 188690 [details]
Patch
Comment 2 Adam Barth 2013-02-19 15:13:01 PST
Comment on attachment 188690 [details]
Patch

This metric isn't really going to tell you anything, unfortunately.  Too much code enumerates the global scope, and that will hide any real usage of this feature.  Perhaps we should instrument the WebKitCSSMatrix constructor itself?
Comment 3 Dirk Schulze 2013-02-19 15:23:17 PST
(In reply to comment #2)
> (From update of attachment 188690 [details])
> This metric isn't really going to tell you anything, unfortunately.  Too much code enumerates the global scope, and that will hide any real usage of this feature.  Perhaps we should instrument the WebKitCSSMatrix constructor itself?

Talked with abarth on IRC. He suggest taking a look at how we instrument new-style notifications. Leaving this on the bug report here as a note. I'll investigate more. Thanks Adam.